Remove synchronisation and increase buffer size.

Author: tecarter94

deploy/tasks/buildah-oci-ta.yaml

@@ -142,7 +142,7 @@ spec:
     - name: BYTE_BUFFER_SIZE
       description: The byte buffer size to use for the domain proxy.
       type: string
-      default: 1024
+      default: 2048
     - name: PROXY_TARGET_WHITELIST
       description: Comma separated whitelist of target hosts for the domain proxy.
       type: string

java-components/domain-proxy/client/src/main/resources/application.properties

@@ -1,6 +1,6 @@
 client-domain-socket=${DOMAIN_SOCKET:/tmp/domain-server}
 client-http-port=8080
-byte-buffer-size=${BYTE_BUFFER_SIZE:1024}
+byte-buffer-size=${BYTE_BUFFER_SIZE:2048}
 quarkus.log.min-level=ALL
 quarkus.log.level=ALL
 quarkus.log.console.format=%d{yyyy-MM-dd HH:mm:ss,SSS} [Domain Proxy Client] %-5p [%c{3.}] (%t) %s%e%n

java-components/domain-proxy/common/src/main/java/com/redhat/hacbs/domainproxy/common/CommonIOUtil.java

@@ -25,12 +25,10 @@ public static Runnable createSocketToChannelWriter(final int byteBufferSize, fin
             LOG.info("Writing from socket to channel");
             try {
                 while ((r = socket.getInputStream().read(buf)) > 0) {
-                    synchronized (channel) {
-                        LOG.infof("Read %d bytes from socket", r);
-                        channel.write(ByteBuffer.wrap(buf, 0, r));
-                        LOG.infof("Wrote %d bytes to channel", r);
-                        bytesWritten += r;
-                    }
+                    LOG.infof("Read %d bytes from socket", r);
+                    channel.write(ByteBuffer.wrap(buf, 0, r));
+                    LOG.infof("Wrote %d bytes to channel", r);
+                    bytesWritten += r;
                 }
             } catch (final ClosedChannelException ignore) {
                 LOG.info("Channel closed");
@@ -68,14 +66,12 @@ public static Runnable createChannelToSocketWriter(final int byteBufferSize, fin
             LOG.info("Writing from channel to socket");
             try {
                 while ((r = channel.read(buf)) > 0) {
-                    synchronized (socket) {
-                        LOG.infof("Read %d bytes from channel", r);
-                        buf.flip();
-                        socket.getOutputStream().write(buf.array(), buf.arrayOffset(), buf.remaining());
-                        LOG.infof("Wrote %d bytes to socket", r);
-                        buf.clear();
-                        bytesWritten += r;
-                    }
+                    LOG.infof("Read %d bytes from channel", r);
+                    buf.flip();
+                    socket.getOutputStream().write(buf.array(), buf.arrayOffset(), buf.remaining());
+                    LOG.infof("Wrote %d bytes to socket", r);
+                    buf.clear();
+                    bytesWritten += r;
                 }
             } catch (final ClosedChannelException ignore) {
                 LOG.info("Channel closed");

java-components/domain-proxy/server/src/main/resources/application.properties

@@ -1,6 +1,6 @@
 server-domain-socket=${DOMAIN_SOCKET:/tmp/domain-server}
 server-http-port=2000
-byte-buffer-size=${BYTE_BUFFER_SIZE:1024}
+byte-buffer-size=${BYTE_BUFFER_SIZE:2048}
 proxy-target-whitelist=${PROXY_TARGET_WHITELIST:repo.maven.apache.org,repository.jboss.org,packages.confluent.io,jitpack.io,repo.gradle.org,plugins.gradle.org}
 quarkus.rest-client.proxy-address=${INTERNAL_PROXY_ADDRESS:indy-generic-proxy:80}
 quarkus.rest-client.proxy-user=${INTERNAL_PROXY_USER}