Just extract cache host. Remove explicit use of env variables when starting server and client. Add some temporary logging of values.

Author: tecarter94

deploy/tasks/buildah-oci-ta.yaml

@@ -390,7 +390,7 @@ spec:
             fi
             echo "Build will be executed with domain proxy"
             echo ${DOMAIN_PROXY_ARGS[@]} # TODO remove
-            ${DOMAIN_PROXY_ARGS[@]} /app/domain-proxy-server-runner & # TODO remove explicit args if unnecessary
+            /app/domain-proxy-server-runner &
             server_pid=$!
           fi
         fi
@@ -494,11 +494,7 @@ spec:
           cat >> /app/build-script.sh << EOF
         #!/bin/sh
         ip link set lo up
-        ${DOMAIN_PROXY_ARGS[@]} /app/domain-proxy-client-runner &  # TODO remove explicit args if unnecessary
-        EOF
-
-        # Without expansion
-          cat > /app/build-script.sh << 'EOF'
+        /app/domain-proxy-client-runner &
         client_pid=$!
         EOF
 

java-components/domain-proxy/client/src/main/java/com/redhat/hacbs/domainproxy/client/DomainProxyClient.java

@@ -41,6 +41,7 @@ public class DomainProxyClient {
     @PostConstruct
     public void start() {
         Log.info("Starting domain proxy client...");
+        Log.infof("Byte buffer size %d", byteBufferSize); // TODO remove
         new Thread(() -> {
             try (final ServerSocket serverSocket = new ServerSocket(clientHttpPort)) {
                 while (running) {

java-components/domain-proxy/server/src/main/java/com/redhat/hacbs/domainproxy/DomainProxyServer.java

@@ -45,6 +45,7 @@ public class DomainProxyServer {
 
     @PostConstruct
     public void start() {
+        Log.infof("Byte buffer size %d", byteBufferSize); // TODO remove
         new Thread(() -> {
             Runtime.getRuntime().addShutdownHook(new Thread(() -> {
                 try {

java-components/domain-proxy/server/src/main/java/com/redhat/hacbs/domainproxy/ExternalProxyVerticle.java

@@ -48,6 +48,7 @@ public ExternalProxyVerticle(final Vertx vertx) {
     @Override
     public void start() {
         Log.info("Starting domain proxy server...");
+        Log.infof("Proxy target whitelist: %s", proxyTargetWhitelist); // TODO remove
         httpServer.requestHandler(request -> {
             if (request.method() == HttpMethod.GET) {
                 handleGetRequest(request);

pkg/reconciler/dependencybuild/buildrecipeyaml.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"github.com/go-logr/logr"
 	v12 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"net/url"
 	"regexp"
 	"strconv"
 	"strings"
@@ -477,6 +478,10 @@ func createPipelineSpec(log logr.Logger, tool string, commitTime int64, jbsConfi
 		},
 	}
 
+	whitelistUrl, err := url.Parse(cacheUrl)
+	if err != nil {
+		return nil, "", err
+	}
 	ps.Tasks = append([]tektonpipeline.PipelineTask{
 		{
 			Name:     BuildTaskName,
@@ -548,14 +553,14 @@ func createPipelineSpec(log logr.Logger, tool string, commitTime int64, jbsConfi
 					Name: "BYTE_BUFFER_SIZE", // TODO remove
 					Value: tektonpipeline.ParamValue{
 						Type:      tektonpipeline.ParamTypeString,
-						StringVal: "1024",
+						StringVal: "2048",
 					},
 				},
 				{
 					Name: "PROXY_TARGET_WHITELIST",
 					Value: tektonpipeline.ParamValue{
 						Type:      tektonpipeline.ParamTypeString,
-						StringVal: cacheUrl,
+						StringVal: whitelistUrl.Host,
 					},
 				},
 			},