Skip to content

Commit d65f882

Browse files
Improve rebuild failed button
1 parent d682ab3 commit d65f882

File tree

4 files changed

+34
-6
lines changed

4 files changed

+34
-6
lines changed

java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/verifier/VerifyBuiltArtifactsCommand.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ private List<String> getExcludes() throws IOException {
241241
newExcludes.addAll(lines);
242242
}
243243

244-
newExcludes.addAll(excludes);
245244
for (var exclude : excludes) {
246245
if (exclude.matches("^[+-^]:.*$")) {
247246
newExcludes.add(exclude.replaceAll("^([+-^])", "^\\\\$1"));

java-components/management-console/src/main/java/com/redhat/hacbs/management/resources/AdminResource.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
package com.redhat.hacbs.management.resources;
22

33
import java.util.HashMap;
4+
import java.util.HashSet;
45
import java.util.Map;
6+
import java.util.Set;
57
import java.util.function.UnaryOperator;
68

79
import jakarta.inject.Inject;
@@ -55,16 +57,28 @@ public void rebuildAll() {
5557
@POST
5658
@Path("rebuild-failed")
5759
public void rebuildFailed() {
60+
Set<String> seen = new HashSet<>();
5861
for (StoredArtifactBuild sb : StoredArtifactBuild.<StoredArtifactBuild> list("state",
5962
ModelConstants.ARTIFACT_BUILD_MISSING)) {
6063
BuildQueue.rebuild(sb.mavenArtifact, false, Map.of());
6164
}
6265
for (StoredArtifactBuild sb : StoredArtifactBuild.<StoredArtifactBuild> list("state",
6366
ModelConstants.ARTIFACT_BUILD_FAILED)) {
64-
BuildQueue.rebuild(sb.mavenArtifact, false, Map.of());
67+
if (sb.buildIdentifier == null || sb.buildIdentifier.dependencyBuildName == null) {
68+
BuildQueue.rebuild(sb.mavenArtifact, false, Map.of());
69+
} else if (!seen.contains(sb.buildIdentifier.dependencyBuildName)) {
70+
BuildQueue.rebuild(sb.mavenArtifact, false, Map.of());
71+
seen.add(sb.buildIdentifier.dependencyBuildName);
72+
}
6573
}
6674
}
6775

76+
@POST
77+
@Path("clear-build-queue")
78+
public void clearBuildQueue() {
79+
BuildQueue.deleteAll();
80+
}
81+
6882
@POST
6983
@Path("import-froms3")
7084
public void s3Import() {

java-components/management-console/src/main/webui/src/app/ControlPanel/ControlPanel.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,25 +19,30 @@ const ControlPanel: React.FunctionComponent = () => {
1919
<CardBody>
2020
<ActionList>
2121
<ActionListItem>
22-
<Button variant="danger" id="rebuild-all" onClick={() => AdminResourceService.postApiAdminRebuildAll()}>
22+
<Button variant="danger" id="rebuild-all" onClick={AdminResourceService.postApiAdminRebuildAll}>
2323
Rebuild All
2424
</Button>
2525
</ActionListItem>
2626
<ActionListItem>
27-
<Button variant="warning" id="rebuild-failed" onClick={() => AdminResourceService.postApiAdminRebuildFailed()}>
27+
<Button variant="warning" id="rebuild-failed" onClick={AdminResourceService.postApiAdminRebuildFailed}>
2828
Rebuild Failed
2929
</Button>
3030
</ActionListItem>
3131
<ActionListItem>
32-
<Button variant="danger" id="rebuild-failed" onClick={() => AdminResourceService.postApiAdminCleanOutDatabase()}>
32+
<Button variant="danger" id="rebuild-failed" onClick={AdminResourceService.postApiAdminCleanOutDatabase}>
3333
Delete All Data
3434
</Button>
3535
</ActionListItem>
3636
<ActionListItem>
37-
<Button variant="warning" id="s3-import" onClick={() => AdminResourceService.postApiAdminImportFroms3()}>
37+
<Button variant="warning" id="s3-import" onClick={AdminResourceService.postApiAdminImportFroms3}>
3838
S3 Import
3939
</Button>
4040
</ActionListItem>
41+
<ActionListItem>
42+
<Button variant="warning" id="s3-import" onClick={AdminResourceService.postApiAdminClearBuildQueue}>
43+
Clear Build Queue
44+
</Button>
45+
</ActionListItem>
4146
</ActionList>
4247
</CardBody>
4348
</Card>

java-components/management-console/src/main/webui/src/services/openapi/services/AdminResourceService.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,16 @@ export class AdminResourceService {
1616
url: '/api/admin/clean-out-database',
1717
});
1818
}
19+
/**
20+
* @returns any Created
21+
* @throws ApiError
22+
*/
23+
public static postApiAdminClearBuildQueue(): CancelablePromise<any> {
24+
return __request(OpenAPI, {
25+
method: 'POST',
26+
url: '/api/admin/clear-build-queue',
27+
});
28+
}
1929
/**
2030
* @returns any Created
2131
* @throws ApiError

0 commit comments

Comments
 (0)