diff --git a/deploy/tasks/maven-deployment.yaml b/deploy/tasks/maven-deployment.yaml index 583a810fc..827dedb68 100644 --- a/deploy/tasks/maven-deployment.yaml +++ b/deploy/tasks/maven-deployment.yaml @@ -28,6 +28,10 @@ spec: - name: MVN_PASSWORD description: Name of the secret holding the Maven repository password type: string + - name: ACCESS_TOKEN + description: Access token for OAuth. + type: string + default: "" - name: JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE description: Name of the processor image. Useful to override for development. type: string @@ -71,6 +75,8 @@ spec: secretKeyRef: name: $(params.MVN_PASSWORD) key: mavenpassword + - name: ACCESS_TOKEN + value: $(params.ACCESS_TOKEN) args: - deploy - --directory=/var/workdir/deployment diff --git a/java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/build/preprocessor/AbstractPreprocessor.java b/java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/build/preprocessor/AbstractPreprocessor.java index b1cae3364..22ab09c3d 100644 --- a/java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/build/preprocessor/AbstractPreprocessor.java +++ b/java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/build/preprocessor/AbstractPreprocessor.java @@ -213,7 +213,8 @@ private String getContainerFile() { * altDeploymentDirectory to be used by default. */ private String getMavenSetup() { - String result = """ + + return """ echo "MAVEN_HOME:$MAVEN_HOME" PATH="${MAVEN_HOME}/bin:$PATH" @@ -243,9 +244,6 @@ private String getMavenSetup() { secondary - - true - artifacts @@ -269,9 +267,6 @@ private String getMavenSetup() { local-deployment - - true - local::file://${JBS_WORKDIR}/artifacts @@ -280,12 +275,12 @@ private String getMavenSetup() { - false - """; + + secondary + local-deployment + - // This block is only needed when running outside of JBS - if (isEmpty(System.getenv("jvm-build-service"))) { - result += """ + false + false http - indy-generic-proxy + domain-proxy 80 ${BUILD_ID}+tracking - ${MVN_TOKEN} + ${ACCESS_TOKEN} ${PROXY_URL}|localhost indy-https - true + false https - indy-generic-proxy + domain-proxy 80 ${BUILD_ID}+tracking - ${MVN_TOKEN} + ${ACCESS_TOKEN} ${PROXY_URL}|localhost - """; - } - result += """ EOF @@ -368,8 +360,6 @@ private String getMavenSetup() { EOF """.formatted(javaVersion); - - return result; } diff --git a/pkg/apis/jvmbuildservice/v1alpha1/systemconfig_types.go b/pkg/apis/jvmbuildservice/v1alpha1/systemconfig_types.go index 8f6a33fd7..f4c04757e 100644 --- a/pkg/apis/jvmbuildservice/v1alpha1/systemconfig_types.go +++ b/pkg/apis/jvmbuildservice/v1alpha1/systemconfig_types.go @@ -49,5 +49,5 @@ const ( KonfluxGitDefinition = "https://raw.githubusercontent.com/konflux-ci/build-definitions/refs/heads/main/task/git-clone/0.1/git-clone.yaml" KonfluxPreBuildDefinitions = "https://raw.githubusercontent.com/redhat-appstudio/jvm-build-service/main/deploy/tasks/pre-build.yaml" KonfluxBuildDefinitions = "https://raw.githubusercontent.com/konflux-ci/build-definitions/refs/heads/main/task/buildah-oci-ta/0.2/buildah-oci-ta.yaml" - KonfluxMavenDeployDefinitions = "https://raw.githubusercontent.com/redhat-appstudio/jvm-build-service/main/deploy/tasks/maven-deployment.yaml" + KonfluxMavenDeployDefinitions = "https://raw.githubusercontent.com/rnc/jvm-build-service/TOKEN/deploy/tasks/maven-deployment.yaml" ) diff --git a/pkg/reconciler/dependencybuild/dependencybuild.go b/pkg/reconciler/dependencybuild/dependencybuild.go index b377f59de..9edb859ce 100644 --- a/pkg/reconciler/dependencybuild/dependencybuild.go +++ b/pkg/reconciler/dependencybuild/dependencybuild.go @@ -611,24 +611,17 @@ func (r *ReconcileDependencyBuild) handleStateBuilding(ctx context.Context, db * }, }}, } - // Setting a default environment variable to represent being run inside the operator - pr.Spec.TaskRunTemplate = tektonpipeline.PipelineTaskRunTemplate{ - PodTemplate: &pod.Template{ - Env: []v1.EnvVar{ - { - Name: util.ControllerNamespace, - Value: util.ControllerDeploymentName, - }, - }, - }, - } if orasOptions != "" { - pr.Spec.TaskRunTemplate.PodTemplate.Env = append([]v1.EnvVar{ - { - Name: "ORAS_OPTIONS", - Value: orasOptions, + pr.Spec.TaskRunTemplate = tektonpipeline.PipelineTaskRunTemplate{ + PodTemplate: &pod.Template{ + Env: []v1.EnvVar{ + { + Name: "ORAS_OPTIONS", + Value: orasOptions, + }, + }, }, - }, pr.Spec.TaskRunTemplate.PodTemplate.Env...) + } } if jbsConfig.Annotations != nil && jbsConfig.Annotations[jbsconfig.CITests] == "true" {