Skip to content

Conversation

@rnc
Copy link
Collaborator

@rnc rnc commented Nov 6, 2024

Potentially a better solution than #2261

@openshift-ci openshift-ci bot requested a review from vibe13 November 6, 2024 10:08
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.81%. Comparing base (70a533a) to head (e87fc24).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2263      +/-   ##
============================================
+ Coverage     43.11%   43.81%   +0.69%     
  Complexity      803      803              
============================================
  Files           241      275      +34     
  Lines          8359    13245    +4886     
  Branches       1345     1345              
============================================
+ Hits           3604     5803    +2199     
- Misses         4355     6844    +2489     
- Partials        400      598     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc
Copy link
Collaborator Author

rnc commented Nov 6, 2024

Closing this in favour of #2261 after discussion with @matejonnet

@rnc rnc closed this Nov 6, 2024
@rnc rnc deleted the PROXY branch November 6, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant