Skip to content

Conversation

@rnc
Copy link
Collaborator

@rnc rnc commented Nov 22, 2024

Due to https://www.github.com/tektoncd/pipeline/issues/8249 its not possible to mark the secret as optional in tekton so by removing it from the yaml this makes it easier to reuse that yaml for the pnc pipeline while keeping the env var for the CI

@openshift-ci openshift-ci bot requested a review from vibe13 November 22, 2024 12:24
@rnc rnc merged commit fa3f5bb into redhat-appstudio:main Nov 22, 2024
24 checks passed
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (cdd75ae) to head (acfe8dc).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/dependencybuild/dependencybuild.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2282      +/-   ##
============================================
+ Coverage     43.78%   43.82%   +0.04%     
+ Complexity      803      802       -1     
============================================
  Files           275      275              
  Lines         13250    13263      +13     
  Branches       1346     1346              
============================================
+ Hits           5802     5813      +11     
- Misses         6850     6851       +1     
- Partials        598      599       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rnc rnc deleted the VOLUME branch December 9, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant