Error reporting in DeploymentTarget/DeploymentTargetClaim.

Error reporting in DeploymentTarget/DeploymentTargetClaim.

Author: Jayendra Parsai

appstudio-controller/controllers/appstudio.redhat.com/deploymenttarget_controller.go

@@ -23,6 +23,7 @@ import (
 
 	codereadytoolchainv1alpha1 "github.com/codeready-toolchain/api/api/v1alpha1"
 	"github.com/codeready-toolchain/toolchain-common/pkg/condition"
+	"github.com/go-logr/logr"
 	applicationv1alpha1 "github.com/redhat-appstudio/application-api/api/v1alpha1"
 	sharedutil "github.com/redhat-appstudio/managed-gitops/backend-shared/util"
 	logutil "github.com/redhat-appstudio/managed-gitops/backend-shared/util/log"
@@ -45,7 +46,10 @@ type DeploymentTargetReconciler struct {
 }
 
 const (
-	FinalizerDT = "dt.appstudio.redhat.com/finalizer"
+	FinalizerDT                                = "dt.appstudio.redhat.com/finalizer"
+	DeploymentTargetConditionTypeErrorOccurred = "ValidDeploymentTargetClaim"
+	DeploymentTargetReasonErrorOccurred        = "ErrorOccurred"
+	DeploymentTargetReasonBound                = "Bound"
 )
 
 //+kubebuilder:rbac:groups=appstudio.redhat.com,resources=deploymenttargetclaims,verbs=get;list;watch;update;patch
@@ -97,6 +101,12 @@ func (r *DeploymentTargetReconciler) Reconcile(ctx context.Context, req ctrl.Req
 
 	// Retrieve and sanity check the DeploymentTargetClass of the DT
 	dtClass, err := findMatchingDTClassForDT(ctx, dt, r.Client)
+	// Update Status.Conditions field of DeploymentTarget.
+	if err := updateStatusConditionOfDeploymentTarget(ctx, r.Client, "failed to retrieve DeploymentTargetClass of DeploymentTarget",
+		&dt, DeploymentTargetConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetReasonErrorOccurred, log); err != nil {
+		return ctrl.Result{}, fmt.Errorf("unable to update deployment target status condition. %v", err)
+	}
+
 	if err != nil {
 		if apierr.IsNotFound(err) {
 			return ctrl.Result{}, nil
@@ -107,6 +117,13 @@ func (r *DeploymentTargetReconciler) Reconcile(ctx context.Context, req ctrl.Req
 		dtClass.Spec.ReclaimPolicy != applicationv1alpha1.ReclaimPolicy_Retain {
 
 		log.Error(nil, "unexpected reclaim policy value on DTClass", "reclaimPolicy", dtClass.Spec.ReclaimPolicy)
+
+		// Update Status.Conditions field of DeploymentTarget.
+		if err := updateStatusConditionOfDeploymentTarget(ctx, r.Client, "unexpected reclaim policy value on DeploymentTargetClass",
+			&dt, DeploymentTargetConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetReasonErrorOccurred, log); err != nil {
+			return ctrl.Result{}, fmt.Errorf("unable to update deployment target status condition. %v", err)
+		}
+
 		return ctrl.Result{}, nil
 	}
 
@@ -140,6 +157,12 @@ func (r *DeploymentTargetReconciler) Reconcile(ctx context.Context, req ctrl.Req
 
 	if dt.DeletionTimestamp == nil {
 		// The DeploymentTarget is not currently being deleted, so no more work to do.
+		// Update Status.Conditions field of DeploymentTarget.
+		if err := updateStatusConditionOfDeploymentTarget(ctx, r.Client, "",
+			&dt, DeploymentTargetConditionTypeErrorOccurred, metav1.ConditionTrue, DeploymentTargetReasonBound, log); err != nil {
+			return ctrl.Result{}, fmt.Errorf("unable to update deployment target status condition. %v", err)
+		}
+
 		return ctrl.Result{}, nil
 	}
 
@@ -166,6 +189,13 @@ func (r *DeploymentTargetReconciler) Reconcile(ctx context.Context, req ctrl.Req
 
 	if dtClass.Spec.ReclaimPolicy != applicationv1alpha1.ReclaimPolicy_Delete {
 		log.Error(nil, "Unexpected reclaimPolicy: neither Retain nor Delete.")
+
+		// Update Status.Conditions field of DeploymentTarget.
+		if err := updateStatusConditionOfDeploymentTarget(ctx, r.Client, "unexpected reclaimPolicy: neither Retain nor Delete.",
+			&dt, DeploymentTargetConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetReasonErrorOccurred, log); err != nil {
+			return ctrl.Result{}, fmt.Errorf("unable to update deployment target status condition. %v", err)
+		}
+
 		return ctrl.Result{}, nil
 	}
 
@@ -181,6 +211,13 @@ func (r *DeploymentTargetReconciler) Reconcile(ctx context.Context, req ctrl.Req
 	var readyCond codereadytoolchainv1alpha1.Condition
 	var found bool
 	if readyCond, found = condition.FindConditionByType(sr.Status.Conditions, codereadytoolchainv1alpha1.ConditionReady); !found {
+
+		// Update Status.Conditions field of DeploymentTarget.
+		if err := updateStatusConditionOfDeploymentTarget(ctx, r.Client, fmt.Sprint("failed to find ConditionReady for SpaceRequest: ", sr.Name),
+			&dt, DeploymentTargetConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetReasonErrorOccurred, log); err != nil {
+			return ctrl.Result{}, fmt.Errorf("unable to update deployment target status condition. %v", err)
+		}
+
 		return ctrl.Result{}, fmt.Errorf("failed to find ConditionReady for SpaceRequest %s from %s", sr.Name, sr.Namespace)
 	}
 
@@ -189,6 +226,13 @@ func (r *DeploymentTargetReconciler) Reconcile(ctx context.Context, req ctrl.Req
 
 		log.Info("Deleting SpaceRequest", "spaceRequest", sr)
 		if err := r.Client.Delete(ctx, sr); err != nil {
+
+			// Update Status.Conditions field of DeploymentTarget.
+			if err := updateStatusConditionOfDeploymentTarget(ctx, r.Client, fmt.Sprint("failed to delete SpaceRequest: ", sr.Name),
+				&dt, DeploymentTargetConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target status condition. %v", err)
+			}
+
 			return ctrl.Result{}, err
 		}
 		logutil.LogAPIResourceChangeEvent(sr.Namespace, sr.Name, sr, logutil.ResourceDeleted, log)
@@ -333,3 +377,28 @@ func (r *DeploymentTargetReconciler) findDeploymentTargetsForSpaceRequests(sr cl
 	return []reconcile.Request{{NamespacedName: client.ObjectKeyFromObject(dt)}}
 
 }
+
+// updateStatusConditionOfDeploymentTarget calls SetCondition() with DeploymentTarget conditions
+func updateStatusConditionOfDeploymentTarget(ctx context.Context, client client.Client,
+	message string, deploymentTarget *applicationv1alpha1.DeploymentTarget, conditionType string,
+	status metav1.ConditionStatus, reason string, log logr.Logger) error {
+
+	newCondition := metav1.Condition{
+		Type:    conditionType,
+		Message: message,
+		Status:  status,
+		Reason:  reason,
+	}
+
+	changed, newConditions := insertOrUpdateConditionsInSlice(newCondition, deploymentTarget.Status.Conditions)
+
+	if changed {
+		deploymentTarget.Status.Conditions = newConditions
+
+		if err := client.Status().Update(ctx, deploymentTarget); err != nil {
+			log.Error(err, "unable to update deploymentTarget status condition.")
+			return err
+		}
+	}
+	return nil
+}

appstudio-controller/controllers/appstudio.redhat.com/deploymenttargetclaim_controller.go

@@ -46,6 +46,12 @@ const (
 
 	// DeploymentTargetLabel is the label indicating the DeploymentTarget that's associated with the SpaceRequest
 	DeploymentTargetLabel = "appstudio.openshift.io/dt"
+
+	DeploymentTargetClaimConditionTypeErrorOccurred = "ValidDeploymentTargetClaim"
+
+	DeploymentTargetClaimReasonErrorOccurred = "ErrorOccurred"
+
+	DeploymentTargetClaimReasonBound = "Bound"
 )
 
 // DeploymentTargetClaimReconciler reconciles a DeploymentTargetClaim object
@@ -98,6 +104,14 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 	// Add the deletion finalizer if it is absent.
 	if addFinalizer(&dtc, applicationv1alpha1.FinalizerBinder) {
 		if err := r.Client.Update(ctx, &dtc); err != nil {
+
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client,
+				fmt.Sprintf("failed to add finalizer %s to DeploymentTargetClaim", applicationv1alpha1.FinalizerBinder),
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			return ctrl.Result{}, fmt.Errorf("failed to add finalizer %s to DeploymentTargetClaim %s in namespace %s: %v", applicationv1alpha1.FinalizerBinder, dtc.Name, dtc.Namespace, err)
 		}
 		log.Info("Added finalizer to DeploymentTargetClaim", "finalizer", applicationv1alpha1.FinalizerBinder)
@@ -112,6 +126,13 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 	if dtc.Status.Phase == applicationv1alpha1.DeploymentTargetClaimPhase_Pending && isMarkedForDynamicProvisioning(dtc) {
 		if err := handleProvisioningOfSpaceRequestForDTC(ctx, dtc, r.Client, log); err != nil {
 			log.Error(err, "unable to handle provisioning of space request for dynamic DTC")
+
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "unable to handle provisioning of space request for dynamic DTC",
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			return ctrl.Result{}, err
 		}
 	}
@@ -121,6 +142,13 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 	if isDTCBindingCompleted(dtc) {
 		if err := handleBoundedDeploymentTargetClaim(ctx, r.Client, dtc, log); err != nil {
 			log.Error(err, "failed to process bounded DeploymentTargetClaim")
+
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "failed to process bounded DeploymentTargetClaim",
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			return ctrl.Result{}, err
 		}
 		return ctrl.Result{}, nil
@@ -132,6 +160,13 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 		dt, err := findMatchingDTForDTC(ctx, r.Client, dtc)
 		if err != nil {
 			log.Error(err, "failed to find a DeploymentTarget that matches the DeploymentTargetClaim")
+
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "failed to find a DeploymentTarget that matches the DeploymentTargetClaim",
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			return ctrl.Result{}, err
 		}
 
@@ -141,6 +176,13 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 
 			if err := bindDeploymentTargetClaimToTarget(ctx, r.Client, &dtc, dt, true, log); err != nil {
 				log.Error(err, "failed to bind DeploymentTargetClaim to the DeploymentTarget", "DeploymentTargetName", dt.Name, "Namespace", dt.Name)
+
+				// Update Status.Conditions field of DeploymentTargetClaim.
+				if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "failed to bind DeploymentTargetClaim to the DeploymentTarget",
+					&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+					return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+				}
+
 				return ctrl.Result{}, err
 			}
 
@@ -151,6 +193,13 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 
 		if err := handleDynamicDTCProvisioning(ctx, r.Client, &dtc, log); err != nil {
 			log.Error(err, "failed to handle DeploymentTargetClaim for dynamic provisioning")
+
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "failed to handle DeploymentTargetClaim for dynamic provisioning",
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			return ctrl.Result{}, err
 		}
 		log.Info("Waiting for the DeploymentTarget to be dynamically created by the provisioner")
@@ -188,11 +237,24 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 			// Both DT and DTC refer each other. So bind them together.
 			if err := bindDeploymentTargetClaimToTarget(ctx, r.Client, &dtc, &dt, false, log); err != nil {
 				log.Error(err, "failed to bind DeploymentTargetClaim to the DeploymentTarget", "DeploymentTargetName", dt.Name, "Namespace", dt.Name)
+
+				// Update Status.Conditions field of DeploymentTargetClaim.
+				if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "failed to bind DeploymentTargetClaim to the DeploymentTarget",
+					&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+					return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+				}
+
 				return ctrl.Result{}, err
 			}
 		} else {
 			log.Error(nil, "DeploymentTargetClaim wants to claim a DeploymentTarget that is already claimed", "DeploymentTarget", dt.Name)
 
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "DeploymentTargetClaim wants to claim a DeploymentTarget that is already claimed",
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			// Update the DTC status to Pending since the DT is not available
 			if err := updateDTCStatusPhase(ctx, r.Client, &dtc, applicationv1alpha1.DeploymentTargetClaimPhase_Pending, log); err != nil {
 				return ctrl.Result{}, err
@@ -204,18 +266,38 @@ func (r *DeploymentTargetClaimReconciler) Reconcile(ctx context.Context, req ctr
 		// At this stage, DT isn't claimed by anyone. The current DTC can try to claim it.
 		if err := doesDTMatchDTC(dt, dtc); err != nil {
 			log.Error(err, "DeploymentTarget does not match the specified DeploymentTargetClaim")
+
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "DeploymentTarget does not match the specified DeploymentTargetClaim",
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			return ctrl.Result{}, err
 		}
 
 		err := bindDeploymentTargetClaimToTarget(ctx, r.Client, &dtc, &dt, false, log)
 		if err != nil {
 			log.Error(err, "failed to bind DeploymentTargetClaim to the DeploymentTarget", "DeploymentTargetName", dt.Name, "Namespace", dt.Name)
+
+			// Update Status.Conditions field of DeploymentTargetClaim.
+			if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "failed to bind DeploymentTargetClaim to the DeploymentTarget",
+				&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionFalse, DeploymentTargetClaimReasonErrorOccurred, log); err != nil {
+				return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+			}
+
 			return ctrl.Result{}, err
 		}
 	}
 
 	log.Info("DeploymentTargetClaim bound to DeploymentTarget", "DeploymentTargetName", dt.Name, "Namespace", dt.Namespace)
 
+	// Update Status.Conditions field of DeploymentTargetClaim.
+	if err := updateStatusConditionOfDeploymentTargetClaim(ctx, r.Client, "",
+		&dtc, DeploymentTargetClaimConditionTypeErrorOccurred, metav1.ConditionTrue, DeploymentTargetClaimReasonBound, log); err != nil {
+		return ctrl.Result{}, fmt.Errorf("unable to update deployment target claim status condition. %v", err)
+	}
+
 	return ctrl.Result{}, nil
 }
 
@@ -861,3 +943,28 @@ func createSpaceRequestForDTC(ctx context.Context, k8sClient client.Client, dtc
 
 	return &newSpaceRequest, nil
 }
+
+// updateStatusConditionOfDeploymentTargetClaim calls SetCondition() with DeploymentTargetClaim conditions
+func updateStatusConditionOfDeploymentTargetClaim(ctx context.Context, client client.Client,
+	message string, deploymentTargetClaim *applicationv1alpha1.DeploymentTargetClaim, conditionType string,
+	status metav1.ConditionStatus, reason string, log logr.Logger) error {
+
+	newCondition := metav1.Condition{
+		Type:    conditionType,
+		Message: message,
+		Status:  status,
+		Reason:  reason,
+	}
+
+	changed, newConditions := insertOrUpdateConditionsInSlice(newCondition, deploymentTargetClaim.Status.Conditions)
+
+	if changed {
+		deploymentTargetClaim.Status.Conditions = newConditions
+
+		if err := client.Status().Update(ctx, deploymentTargetClaim); err != nil {
+			log.Error(err, "unable to update deploymentTargetClaim status condition.")
+			return err
+		}
+	}
+	return nil
+}

appstudio-controller/go.mod

@@ -105,6 +105,7 @@ require (
 )
 
 replace (
+	github.com/redhat-appstudio/application-api => github.com/jparsai/application-api v0.0.0-20231204122745-31449b29f5d1
 	github.com/redhat-appstudio/managed-gitops/backend => ../backend
 	github.com/redhat-appstudio/managed-gitops/backend-shared => ../backend-shared
 	github.com/redhat-appstudio/managed-gitops/utilities/db-migration => ../utilities/db-migration

appstudio-controller/go.sum

@@ -252,6 +252,8 @@ github.com/jinzhu/inflection v1.0.0 h1:K317FqzuhWc8YvSVlFMCCUb36O/S9MCKRDI7QkRKD
 github.com/jinzhu/inflection v1.0.0/go.mod h1:h+uFLlag+Qp1Va5pdKtLDYj+kHp5pxUVkryuEj+Srlc=
 github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8HmY=
 github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y=
+github.com/jparsai/application-api v0.0.0-20231204122745-31449b29f5d1 h1:nrwjrVYyGNQMYPmRQJqZ4TeJkk4kO1XTeAMuFJwyc18=
+github.com/jparsai/application-api v0.0.0-20231204122745-31449b29f5d1/go.mod h1:YvckuKHe82eWloGk0/BpSw4YYG2owrGZAanztbOj3pQ=
 github.com/jpillora/backoff v1.0.0/go.mod h1:J/6gKK9jxlEcS3zixgDgUAsiuZ7yrSoa/FX5e0EB2j4=
 github.com/json-iterator/go v1.1.6/go.mod h1:+SdeFBvtyEkXs7REEP0seUULqWtbJapLOCVDaaPEHmU=
 github.com/json-iterator/go v1.1.10/go.mod h1:KdQUCv79m/52Kvf8AW2vK1V8akMuk1QjK/uOdHXbAo4=
@@ -343,8 +345,6 @@ github.com/prometheus/procfs v0.6.0/go.mod h1:cz+aTbrPOrUb4q7XlbU9ygM+/jj0fzG6c1
 github.com/prometheus/procfs v0.7.3/go.mod h1:cz+aTbrPOrUb4q7XlbU9ygM+/jj0fzG6c1xBZuNvfVA=
 github.com/prometheus/procfs v0.8.0 h1:ODq8ZFEaYeCaZOJlZZdJA2AbQR98dSHSM1KW/You5mo=
 github.com/prometheus/procfs v0.8.0/go.mod h1:z7EfXMXOkbkqb9IINtpCn86r/to3BnA0uaxHdg830/4=
-github.com/redhat-appstudio/application-api v0.0.0-20231025105224-2790bb451725 h1:9808yVdQmzCLGrbedW6h4brggYqdnMpyMwKhFpx9/pE=
-github.com/redhat-appstudio/application-api v0.0.0-20231025105224-2790bb451725/go.mod h1:OvmeiVOItG2OSX/QE+vQwzOYfbOMBhBy43ZFxkWZJyc=
 github.com/rogpeppe/fastuuid v1.2.0/go.mod h1:jVj6XXZzXRy/MSR5jhDC/2q6DgLz+nrA6LYCDYWNEvQ=
 github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFRclV5y23lUDJ4=
 github.com/rogpeppe/go-internal v1.6.1/go.mod h1:xXDCJY+GAPziupqXw64V24skbSoqbTEfhy4qGm1nDQc=

manifests/base/crd/overlays/local-dev/kustomization.yaml

@@ -2,6 +2,6 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
 resources:
-- https://github.com/redhat-appstudio/application-api/config/crd?ref=8d112632297181de2d5f209ab98015457d0abf31
+- https://github.com/jparsai/application-api/config/crd?ref=31449b29f5d1c1a42682bbfa2753ef6184a094c0
 - https://github.com/codeready-toolchain/host-operator/config/crd?ref=6c9e07da3665f542448ff46fc91d7fa1bfd83853
 - ../../base