fix: fix auth provider configuration

Previous configuration was using the `.Values.developerHub.authProvider`
value to determine the auth provider to configure. This was not correct
as the auth providers may be needed to access information even if they
they are not used for sign-in.

cf RHTAP-6072.

Author: Roming22

installer/charts/tssc-dh/templates/app-config-content.yaml

@@ -49,24 +49,7 @@ azureDevOps:
 auth:
   environment: production
   providers:
-  {{- $signInPage := "" }}
-  {{- if eq .Values.developerHub.authProvider "oidc" }}
-    {{- $signInPage = "oidc" }}
-    oidc:
-      production:
-        clientId: ${AUTH__OIDC__CLIENT__ID}
-        clientSecret: ${AUTH__OIDC__CLIENT__SECRET}
-        metadataUrl: ${AUTH__OIDC__METADATA__URL}
-        prompt: auto
-        signIn:
-          resolvers:
-          - resolver: preferredUsernameMatchingUserEntityName
-  session:
-    secret:
-      $env: BACKEND_SECRET
-  {{- end }}
-  {{- if eq .Values.developerHub.authProvider "github" }}
-    {{- $signInPage = "github" }}
+  {{- if $githubSecretObj }}
     github:
       production:
         clientId: ${GITHUB__APP__CLIENT__ID}
@@ -81,10 +64,9 @@ auth:
               dangerouslyAllowSignInWithoutUserInCatalog: true
       {{- end }}
   {{- end }}
-  {{- if eq .Values.developerHub.authProvider "gitlab" }}
+  {{- if $gitlabSecretObj }}
     {{- $gitlabSecretData := ($gitlabSecretObj.data | default dict) }}
     {{- if and $gitlabSecretData.clientId $gitlabSecretData.clientSecret }}
-    {{- $signInPage = "gitlab" }}
     gitlab:
       production:
       {{- if ne ($gitlabSecretData.host | b64dec) "gitlab.com" }}
@@ -98,6 +80,20 @@ auth:
               dangerouslyAllowSignInWithoutUserInCatalog: true
     {{- end }}
   {{- end }}
+  {{- if eq .Values.developerHub.authProvider "oidc" }}
+    oidc:
+      production:
+        clientId: ${AUTH__OIDC__CLIENT__ID}
+        clientSecret: ${AUTH__OIDC__CLIENT__SECRET}
+        metadataUrl: ${AUTH__OIDC__METADATA__URL}
+        prompt: auto
+        signIn:
+          resolvers:
+          - resolver: preferredUsernameMatchingUserEntityName
+  session:
+    secret:
+      $env: BACKEND_SECRET
+  {{- end }}
 backend:
   auth:
     keys:
@@ -272,8 +268,8 @@ proxy:
 quay:
   uiUrl: ${QUAY__URL}
 {{- end }}
-{{- if $signInPage }}
-signInPage: {{ $signInPage }}
+{{- if .Values.developerHub.authProvider }}
+signInPage: {{ .Values.developerHub.authProvider }}
 {{- end }}
 techdocs:
   builder: 'local'