Skip to content

Commit bf1c201

Browse files
Merge pull request #341 from otaviof/fix-release-action
RHTAPINST-186: GitHub Release Action vs. Container Image
2 parents 183fde2 + bad68cc commit bf1c201

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

.github/actions/buildah/action.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ inputs:
99
IMAGE_NAMESPACE:
1010
description: Makefile's IMAGE_NAMESPACE variable
1111
required: false
12+
default: ${{ github.repository_owner }}
1213
IMAGE_REPO_USERNAME:
1314
description: Makefile's IMAGE_REPO_USERNAME variable
1415
required: false
1516
default: ${{ github.actor }}
1617
IMAGE_REPO_PASSWORD:
1718
description: Makefile's IMAGE_REPO_PASSWORD variable
18-
required: false
19-
default: ${{ secrets.GITHUB_TOKEN }}
19+
required: true
2020
tags:
2121
description: Comma-separated list of tags to apply to the image
2222
required: false

.github/workflows/release.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,15 @@ jobs:
1616
- uses: actions/checkout@v4
1717
- uses: ./.github/actions/go
1818

19-
- name: Container Image
20-
uses: ./.github/actions/buildah
21-
with:
22-
tags: "latest,${{ github.ref }}"
19+
#
20+
# TODO(otaviof): In order to build this container image, we need Red Hat
21+
# container registry credentials.
22+
#
23+
# - name: Container Image
24+
# uses: ./.github/actions/buildah
25+
# with:
26+
# tags: "latest,${{ github.ref }}"
27+
# IMAGE_REPO_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
2328

2429
- name: GitHub Release
2530
env:

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ CGO_LDFLAGS ?=
1818
GITHUB_REF_NAME ?= ${GITHUB_REF_NAME:-}
1919
GITHUB_TOKEN ?= ${GITHUB_TOKEN:-}
2020

21-
2221
# Container registry credentials.
2322
IMAGE_REPO_USERNAME ?=
2423
IMAGE_REPO_PASSWORD ?=

0 commit comments

Comments
 (0)