Merge pull request #593 from Roming22/fix/cli/template

fix: 'template' subcommand fails when '--show-manifests=false' is used

Author: openshift-merge-bot[bot]

pkg/config/config.go

@@ -50,7 +50,7 @@ func (c *Config) GetDependency(logger *slog.Logger, chart string) (*Dependency,
 			return &dep, nil
 		}
 	}
-	return nil, fmt.Errorf("chart %s not found", chart)
+	return nil, fmt.Errorf("chart '%s' not found", chart)
 }
 
 // GetEnabledDependencies returns a list of enabled dependencies.
@@ -72,7 +72,7 @@ func (c *Config) GetEnabledDependencies(logger *slog.Logger) []Dependency {
 func (c *Config) GetFeature(name string) (*FeatureSpec, error) {
 	feature, ok := c.Installer.Features[name]
 	if !ok {
-		return nil, fmt.Errorf("feature %s not found", name)
+		return nil, fmt.Errorf("feature '%s' not found", name)
 	}
 	return &feature, nil
 }

pkg/subcmd/template.go

@@ -81,9 +81,6 @@ func (t *Template) Complete(args []string) error {
 	// to false it will return a validation error.
 	t.flags.DryRun = true
 
-	if !t.showManifests {
-		return nil
-	}
 	if len(args) != 1 {
 		return fmt.Errorf("expecting one chart, got %d", len(args))
 	}