Double quote variables in ci-test.sh

Variables should be double-quoted to prevent globbing and word splitting.
For more information, see ShellCheck SC2086.

Signed-off-by: Tomáš Nevrlka <[email protected]>

Author: tnevrlka

ci-test.sh

@@ -9,67 +9,69 @@ eval "$(hack/get-trustification-env.sh)"
 SKIP_SECRETS=${SKIP_SECRETS:-false}
 USE_RHTAP_IMAGES=${USE_RHTAP_IMAGES:-false}
 
-if [ $SKIP_SECRETS == "true" ]; then
+if [ "$SKIP_SECRETS" == "true" ]; then
     echo "WARNING SKIP_SECRETS set to true, skipping configuration of secrets"
 fi
-if [ $USE_RHTAP_IMAGES == "true" ]; then
+if [ "$USE_RHTAP_IMAGES" == "true" ]; then
     echo "USE_RHTAP_IMAGES is set to $USE_RHTAP_IMAGES"
     echo "Note - configuration is going to use the runner images and Jenkins from redhat-appstudio"
 else
     echo "USE_RHTAP_IMAGES is set to $USE_RHTAP_IMAGES"
     echo "Note - configuration is going to use the runner images#MY_QUAY_USER and Jenkins MY_GITHUB_USER"
 fi
 
-if [ $TEST_REPO_ORG == "redhat-appstudio" ]; then
+if [ "$TEST_REPO_ORG" == "redhat-appstudio" ]; then
     echo "Cannot do CI testing using the redhat-appstudio org"
     echo "You must create forks in your own org and set up MY_TEST_REPO_ORG (github) and MY_TEST_REPO_GITLAB_ORG"
     exit
 fi
 
 function updateGitAndQuayRefs() {
-    if [ $USE_RHTAP_IMAGES == "true" ]; then
+    if [ "$USE_RHTAP_IMAGES" == "true" ]; then
         echo "USE_RHTAP_IMAGES is set to $USE_RHTAP_IMAGES"
         echo "No images or Jenkins references patched"
     else
         echo "USE_RHTAP_IMAGES is set to $USE_RHTAP_IMAGES"
         echo "images or Jenkins references patched to quay.io/$MY_QUAY_USER and github.com/$MY_GITHUB_USER"
-        if [ -f $1 ]; then
-            sed -i "s!quay.io/redhat-appstudio/rhtap-task-runner.*!quay.io/$MY_QUAY_USER/rhtap-task-runner:dev!g" $1
-            sed -i "s!https://github.com/redhat-appstudio!https://github.com/$MY_GITHUB_USER!g" $1
-            sed -i "s!RHTAP_Jenkins@.*'!RHTAP_Jenkins@dev'!g" $1
+        if [ -f "$1" ]; then
+            sed -i "s!quay.io/redhat-appstudio/rhtap-task-runner.*!quay.io/$MY_QUAY_USER/rhtap-task-runner:dev!g" "$1"
+            sed -i "s!https://github.com/redhat-appstudio!https://github.com/$MY_GITHUB_USER!g" "$1"
+            sed -i "s!RHTAP_Jenkins@.*'!RHTAP_Jenkins@dev'!g" "$1"
         fi
     fi
 }
 
 function updateBuild() {
     REPO=$1
     GITOPS_REPO_UPDATE=$2
-    mkdir -p $REPO/rhtap
+    mkdir -p "$REPO/rhtap"
     SETUP_ENV=$REPO/rhtap/env.sh
-    cp rhtap/env.template.sh $SETUP_ENV
-    sed -i "s!\${{ values.image }}!$IMAGE_TO_BUILD!g" $SETUP_ENV
-    sed -i "s!\${{ values.dockerfile }}!Dockerfile!g" $SETUP_ENV
-    sed -i "s!\${{ values.buildContext }}!.!g" $SETUP_ENV
-    sed -i "s!\${{ values.repoURL }}!$GITOPS_REPO_UPDATE!g" $SETUP_ENV
+    cp rhtap/env.template.sh "$SETUP_ENV"
+    sed -i "s!\${{ values.image }}!$IMAGE_TO_BUILD!g" "$SETUP_ENV"
+    sed -i "s!\${{ values.dockerfile }}!Dockerfile!g" "$SETUP_ENV"
+    sed -i "s!\${{ values.buildContext }}!.!g" "$SETUP_ENV"
+    sed -i "s!\${{ values.repoURL }}!$GITOPS_REPO_UPDATE!g" "$SETUP_ENV"
     # Update REKOR_HOST and TUF_MIRROR values directly
-    sed -i '/export REKOR_HOST=/d' $SETUP_ENV
-    sed -i '/export TUF_MIRROR=/d' $SETUP_ENV
-    sed -i '/export IGNORE_REKOR=/d' $SETUP_ENV
-
-    echo "" >> $SETUP_ENV
-    echo "export REKOR_HOST=$REKOR_HOST" >> $SETUP_ENV
-    echo "export IGNORE_REKOR=$IGNORE_REKOR" >> $SETUP_ENV
-    echo "export TUF_MIRROR=$TUF_MIRROR" >> $SETUP_ENV
-    echo "# Update forced CI test $(date)" >> $SETUP_ENV
+    sed -i '/export REKOR_HOST=/d' "$SETUP_ENV"
+    sed -i '/export TUF_MIRROR=/d' "$SETUP_ENV"
+    sed -i '/export IGNORE_REKOR=/d' "$SETUP_ENV"
+
+    {
+        echo ""
+        echo "export REKOR_HOST=$REKOR_HOST"
+        echo "export IGNORE_REKOR=$IGNORE_REKOR"
+        echo "export TUF_MIRROR=$TUF_MIRROR"
+        echo "# Update forced CI test $(date)"
+    } >> "$SETUP_ENV"
 
     if [[ "$TEST_PRIVATE_REGISTRY" == "true" ]]; then
         echo "WARNING Due to private repos, disabling ACS"
-        sed -i '/export DISABLE_ACS=/d' $SETUP_ENV
-        echo "export DISABLE_ACS=true" >> $SETUP_ENV
+        sed -i '/export DISABLE_ACS=/d' "$SETUP_ENV"
+        echo "export DISABLE_ACS=true" >> "$SETUP_ENV"
     fi
 
-    updateGitAndQuayRefs $SETUP_ENV
-    cat $SETUP_ENV
+    updateGitAndQuayRefs "$SETUP_ENV"
+    cat "$SETUP_ENV"
 }
 
 # create latest images for dev github and gitlab
@@ -79,12 +81,12 @@ bash hack/update-jenkins-library
 
 # Repos on github and gitlab, github and jenkins
 # source repos are updated with the name of the corresponding GITOPS REPO for update-deployment
-updateBuild $BUILD $TEST_GITOPS_REPO
-updateBuild $GITOPS
-updateBuild $GITLAB_BUILD $TEST_GITOPS_GITLAB_REPO
-updateBuild $GITLAB_GITOPS
-updateBuild $JENKINS_BUILD $TEST_GITOPS_JENKINS_REPO
-updateBuild $JENKINS_GITOPS
+updateBuild "$BUILD" "$TEST_GITOPS_REPO"
+updateBuild "$GITOPS"
+updateBuild "$GITLAB_BUILD" "$TEST_GITOPS_GITLAB_REPO"
+updateBuild "$GITLAB_GITOPS"
+updateBuild "$JENKINS_BUILD" "$TEST_GITOPS_JENKINS_REPO"
+updateBuild "$JENKINS_GITOPS"
 
 # source repos for copying the generated manifests
 GEN_SRC=generated/source-repo
@@ -93,31 +95,31 @@ GEN_GITOPS=generated/gitops-template
 #Jenkins
 echo "Update Jenkins file in $JENKINS_BUILD and $JENKINS_GITOPS"
 echo "NEW - JENKINS USES A SEPARATE REPO FROM GITHUB ACTIONS"
-cp $GEN_SRC/jenkins/Jenkinsfile $JENKINS_BUILD/Jenkinsfile
-cp $GEN_GITOPS/jenkins/Jenkinsfile $JENKINS_GITOPS/Jenkinsfile
-updateGitAndQuayRefs $JENKINS_BUILD/Jenkinsfile
-updateGitAndQuayRefs $JENKINS_GITOPS/Jenkinsfile
+cp $GEN_SRC/jenkins/Jenkinsfile "$JENKINS_BUILD"/Jenkinsfile
+cp $GEN_GITOPS/jenkins/Jenkinsfile "$JENKINS_GITOPS"/Jenkinsfile
+updateGitAndQuayRefs "$JENKINS_BUILD"/Jenkinsfile
+updateGitAndQuayRefs "$JENKINS_GITOPS"/Jenkinsfile
 
 # Gitlab CI
 echo "Update .gitlab-ci.yml file in $GITLAB_BUILD and $GITLAB_GITOPS"
-cp $GEN_SRC/gitlabci/.gitlab-ci.yml $GITLAB_BUILD/.gitlab-ci.yml
-cp $GEN_GITOPS/gitlabci/.gitlab-ci.yml $GITLAB_GITOPS/.gitlab-ci.yml
-updateGitAndQuayRefs $GITLAB_BUILD/.gitlab-ci.yml
-updateGitAndQuayRefs $GITLAB_GITOPS/.gitlab-ci.yml
+cp $GEN_SRC/gitlabci/.gitlab-ci.yml "$GITLAB_BUILD"/.gitlab-ci.yml
+cp $GEN_GITOPS/gitlabci/.gitlab-ci.yml "$GITLAB_GITOPS"/.gitlab-ci.yml
+updateGitAndQuayRefs "$GITLAB_BUILD"/.gitlab-ci.yml
+updateGitAndQuayRefs "$GITLAB_GITOPS"/.gitlab-ci.yml
 
 # Github Actions
 echo "Update .github workflows in $BUILD and $GITOPS"
-cp -r $GEN_SRC/githubactions/.github $BUILD
-cp -r $GEN_GITOPS/githubactions/.github $GITOPS
-for wf in $BUILD/.github/workflows/* $GITOPS/.github/workflows/*; do
-    updateGitAndQuayRefs $wf
+cp -r $GEN_SRC/githubactions/.github "$BUILD"
+cp -r $GEN_GITOPS/githubactions/.github "$GITOPS"
+for wf in "$BUILD"/.github/workflows/* "$GITOPS"/.github/workflows/*; do
+    updateGitAndQuayRefs "$wf"
 done
 
 function updateRepos() {
     REPO=$1
     echo
     echo "Updating $REPO"
-    pushd $REPO
+    pushd "$REPO"
     git add .
     git commit -m "Testing in CI"
     git push
@@ -127,30 +129,30 @@ function updateRepos() {
 # set secrets and then push to repos to ensure pipeline runs are
 # with correct values
 # github
-if [ $SKIP_SECRETS == "false" ]; then
-    bash hack/ghub-set-vars $TEST_BUILD_REPO
-    bash hack/ghub-set-vars $TEST_GITOPS_REPO
+if [ "$SKIP_SECRETS" == "false" ]; then
+    bash hack/ghub-set-vars "$TEST_BUILD_REPO"
+    bash hack/ghub-set-vars "$TEST_GITOPS_REPO"
 fi
 
-updateRepos $BUILD
-updateRepos $GITOPS
+updateRepos "$BUILD"
+updateRepos "$GITOPS"
 
 # gitlab
-if [ $SKIP_SECRETS == "false" ]; then
-    bash hack/glab-set-vars $(basename $TEST_BUILD_GITLAB_REPO)
-    bash hack/glab-set-vars $(basename $TEST_GITOPS_GITLAB_REPO)
+if [ "$SKIP_SECRETS" == "false" ]; then
+    bash hack/glab-set-vars "$(basename "$TEST_BUILD_GITLAB_REPO")"
+    bash hack/glab-set-vars "$(basename "$TEST_GITOPS_GITLAB_REPO")"
 fi
-updateRepos $GITLAB_BUILD
-updateRepos $GITLAB_GITOPS
+updateRepos "$GITLAB_BUILD"
+updateRepos "$GITLAB_GITOPS"
 
 # Jenkins
 # note, jenkins secrets are global so set once"
-if [ $SKIP_SECRETS == "false" ]; then
+if [ "$SKIP_SECRETS" == "false" ]; then
     bash hack/jenkins-set-secrets
 fi
-updateRepos $JENKINS_BUILD
-updateRepos $JENKINS_GITOPS
-bash hack/jenkins-run-pipeline $(basename $TEST_BUILD_JENKINS_REPO)
+updateRepos "$JENKINS_BUILD"
+updateRepos "$JENKINS_GITOPS"
+bash hack/jenkins-run-pipeline "$(basename "$TEST_BUILD_JENKINS_REPO")"
 
 echo
 echo "Github Build and Gitops Repos"