Adds a new QE test for the performance-cpu-pinning-no-exec-probes test case that was recently refactored in the certsuite repository.
#1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed old networking-dpdk-cpu-pinning-exec-probe test - Created new performance-cpu-pinning-no-exec-probes test (DPDK-specific) - Added DefineDpdkPod() helper function in performance/helper - Added DpdkPodName and CertsuiteCPUPinningNoExecProbes constants - Test checks DPDK pods with SR-IOV for exec probes - Maintains narrow DPDK-only scope with SR-IOV operator requirement Files modified: - tests/networking/helper/helper.go (removed DefineDpdkPod) - tests/networking/helper/helper_test.go (removed TestDefineDpdkPod) - tests/networking/parameters/parameters.go (removed old constants) - tests/performance/helper/helper.go (added DefineDpdkPod) - tests/performance/parameters/parameters.go (added constants) Files added: - tests/performance/tests/cpu_pinning_no_exec_probes.go - tests/performance/tests/cpu_pinning_no_exec_probes_test.go Files deleted: - tests/networking/tests/networking_dpdk_cpu_pinning_exec_probe.go
acornett21
reviewed
Nov 11, 2025
| NetworkingTestSkipLabel = map[string]string{"redhat-best-practices-for-k8s.com/skip_connectivity_tests": ""} | ||
| NetworkingTestMultusSkipLabel = map[string]string{"redhat-best-practices-for-k8s.com/skip_multus_connectivity_tests": ""} | ||
| NetworkingTestSkipLabel = map[string]string{"redhat-best-practices-for-k8s.com/skip_connectivity_tests": ""} | ||
| NetworkingTestMultusSkipLabel = map[string]string{"redhat-best-practices-for-k8s.com/skip_multus_connectivity_tests": ""} |
There was a problem hiding this comment.
@sebrandon1 How did this pass linting before? It looks like someone manual adjusted the formatting, which isn't great, can we just update the linter? Otherwise every PR in this file has to be manually edited.
Member
There was a problem hiding this comment.
@rocrisp Just add an "Enter" between the lines and the gofmt will fix it. It's just since the variables are now "together" the gofmt is trying to space everything the same.
- Separate string constants from map constants with blank line - Allows gofmt to align each group independently - Addresses reviewer feedback on formatting alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The upstream certsuite test
networking-dpdk-cpu-pinning-exec-probewas refactored and moved:networking-dpdk-cpu-pinning-exec-probe(networking suite)performance-cpu-pinning-no-exec-probes(performance suite)This PR updates the QE test suite to reflect that change while maintaining the DPDK-specific scope with SR-IOV operator requirements.
Changes Made
🗑️ Removed (from networking suite):
tests/networking/tests/networking_dpdk_cpu_pinning_exec_probe.go- Old test filetests/networking/helper/helper.go- RemovedDefineDpdkPod()function (65 lines)tests/networking/helper/helper_test.go- RemovedTestDefineDpdkPod()unit test (57 lines)tests/networking/parameters/parameters.go- Removed constants:CertsuiteDpdkCPUPinningExecProbeCertsuiteNetworkingDpdkExecProbeTcNameDpdkPodName➕ Added (to performance suite):
tests/performance/tests/cpu_pinning_no_exec_probes.go- New QE test implementationtests/performance/tests/cpu_pinning_no_exec_probes_test.go- Unit test filetests/performance/helper/helper.go- AddedDefineDpdkPod()function (63 lines)tests/performance/parameters/parameters.go- Added constants:CertsuiteCPUPinningNoExecProbes = "performance-cpu-pinning-no-exec-probes"DpdkPodName = "dpdk-pod"Test Coverage
The new test includes 2 test scenarios: