Fix shellcheck errors (#219)

Author: rdavid

.github/workflows/pre-main.yml

@@ -1,10 +1,10 @@
+---
 name: Test Incoming Changes
-
-on:
+'on':
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
   workflow_dispatch:
 
 jobs:
@@ -33,8 +33,6 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v3
-      - name: Run ShellCheck
-        uses: ludeeus/action-shellcheck@master
+      - uses: ludeeus/action-shellcheck@master
         with:
-          scandir: './scripts'
-          severity: error
+          ignore_names: mo

config/vagrant/scripts/bootstrap-cluster.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+# shellcheck disable=SC2207
 
 # Download and install Kubernetes In Docker (Kind):
 sudo curl -Lo /usr/bin/kind https://github.com/kubernetes-sigs/kind/releases/download/v0.14.0/kind-linux-amd64
@@ -13,12 +14,12 @@ OPENSHIFT_VERSION=${SORTED_VERSIONS[${#SORTED_VERSIONS[@]} - 1]}
 OC_BIN_TAR="openshift-client-linux.tar.gz"
 OC_DL_URL="https://mirror.openshift.com/pub/openshift-v4/clients/ocp"/${OPENSHIFT_VERSION}/${OC_BIN_TAR}
 
-curl -Lo oc.tar.gz ${OC_DL_URL}
+curl -Lo oc.tar.gz "${OC_DL_URL}"
 tar -xvf oc.tar.gz
 chmod +x oc kubectl
 sudo cp oc kubectl /usr/bin/.
 
 # create cluster
-cd partner
+cd partner || exit 1
 make rebuild-cluster
-make install 
+make install

config/vagrant/scripts/bootstrap-docker.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 dnf update -y
 echo "192.168.56.10  k8shost" >> /etc/hosts
-        
+
 # Adding docker repository
 sudo dnf config-manager \
     --add-repo \
@@ -65,7 +65,7 @@ sudo systemctl enable containerd.service
 
 # Perform the post install ( https://docs.docker.com/engine/install/linux-postinstall )
 sudo groupadd docker
-sudo usermod -aG docker $USER
+sudo usermod -aG docker "$USER"
 
 # ensures docker is running
 #STATE=""

scripts/clean-all.sh

@@ -2,6 +2,8 @@
 
 # Initialization
 SCRIPT_DIR=$(dirname "$0")
+
+# shellcheck disable=SC1091 # Not following.
 source "$SCRIPT_DIR"/init-env.sh
 
 # Delete debug pods

scripts/clean.sh

@@ -2,6 +2,8 @@
 
 # Initialization
 SCRIPT_DIR=$(dirname "$0")
+
+# shellcheck disable=SC1091 # Not following.
 source "$SCRIPT_DIR"/init-env.sh
 
 # Delete tnf, partner and operator and litmus

scripts/configure-docker.sh

@@ -2,6 +2,8 @@
 
 # Initialization
 SCRIPT_DIR=$(dirname "$0")
+
+# shellcheck disable=SC1091 # Not following.
 source "$SCRIPT_DIR"/init-env.sh
 
 # update docker config

scripts/create-local-registry.sh

@@ -1,7 +1,10 @@
 #!/usr/bin/env bash
 # TODO: needs refactoring to work with kind
 # Initialization
+# shellcheck disable=SC1001,SC2215
 SCRIPT_DIR=$(dirname "$0")
+
+# shellcheck disable=SC1091 # Not following.
 source "$SCRIPT_DIR"/init-env.sh
 
 #setting sudo
@@ -42,12 +45,13 @@ sudo $CERT_UPDATER
 
 
 # Add the hostname to /etc/hosts
-if [ -z $( grep "$REGISTRY_NAME" /etc/hosts) ]
+# shellcheck disable=SC2143 # Use grep -q.
+if [ -z "$( grep "$REGISTRY_NAME" /etc/hosts)" ]
 then
   REGISTRY_ADDRESS=$(hostname -I|awk '{print $1}')
   echo REGISTRY_ADDRESS= "$REGISTRY_ADDRESS" 
   sudo REGISTRY_ADDRESS1="$REGISTRY_ADDRESS" REGISTRY1="$REGISTRY_NAME" sh -c 'echo "$REGISTRY_ADDRESS1 $REGISTRY1" >> /etc/hosts'
-else 
+else
   echo "entry already present"
 fi
 cat /etc/hosts
@@ -65,7 +69,7 @@ ${CONTAINER_CLIENT} rm -f registry
 
 # Create the docker registry
 ${CONTAINER_CLIENT} run -d \Linux
-  -v $(pwd)/"$SCRIPT_DIR"/certs:/certs:Z \
+  -v "$(pwd)"/"$SCRIPT_DIR"/certs:/certs:Z \
   -e REGISTRY_HTTP_ADDR=0.0.0.0:443 \
   -e REGISTRY_HTTP_TLS_CERTIFICATE=/certs/registry.crt \
   -e REGISTRY_HTTP_TLS_KEY=/certs/registry.key \

scripts/create-operator-bundle.sh

@@ -2,6 +2,8 @@
 
 # Initialization
 SCRIPT_DIR=$(dirname "$0")
+
+# shellcheck disable=SC1091 # Not following.
 source "$SCRIPT_DIR"/init-env.sh
 
 # Login to the registry

scripts/create-redhat-registry-secrets.sh

@@ -2,6 +2,8 @@
 
 # Initialization
 SCRIPT_DIR=$(dirname "$0")
+
+# shellcheck disable=SC1091 # Not following.
 source "$SCRIPT_DIR"/init-env.sh
 
 oc create secret docker-registry redhat-registry-secret \

scripts/create-secret.sh

@@ -2,6 +2,8 @@
 
 # Initialization
 SCRIPT_DIR=$(dirname "$0")
+
+# shellcheck disable=SC1091 # Not following.
 source "$SCRIPT_DIR"/init-env.sh
 
 #check pem file exists, create a secret with it if present