Multinode support (#24)

Update action.yaml to support multiple nodes

Author: edcdavid

.github/actions/create-local-test-infra-resources/action.yaml

@@ -8,6 +8,9 @@ inputs:
   oc_pod_timeout:
     description: "Timeout for the `oc wait` command"
     default: 90s
+  put_deployment_name:
+    description: "The expected value of the test deployment name"
+    default: test
   put_pod_label_app:
     description: "The expected value of the test pod's `app` label"
     default: test
@@ -33,23 +36,27 @@ runs:
       run: oc config set-context $(oc config current-context) --namespace=${{ inputs.oc_namespace }}
       shell: bash
 
-    - name: (PUT) Wait for the test pod to be ready
-      run: oc wait pod --for=condition=ready -l "app=${{ inputs.put_pod_label_app }}" --timeout=${{ inputs.oc_pod_timeout }}
+    - name: (PUT) Wait for the test deployment to be available
+      run: oc wait deployment ${{ inputs.put_deployment_name }} --for=condition=available --timeout=${{ inputs.oc_pod_timeout }} 
       shell: bash
 
     - name: (TPP) Wait for the partner pod to be ready
       run: oc wait pod --for=condition=ready -l "app=${{ inputs.tpp_pod_label_app }}" --timeout=${{ inputs.oc_pod_timeout }}
       shell: bash
 
-    - name: (PUT) Ensure only one pod with the label is present
-      run: '[[ $(oc get pods -l "app=${{ inputs.put_pod_label_app }}" -o name | wc -l) -eq "1" ]]'
+    - name: Display all pods in namespace
+      run: oc get pods -o wide
+      shell: bash
+
+    - name: (PUT) Ensure that two pods with the label are present
+      run: '[[ $(oc get pods -l "app=${{ inputs.put_pod_label_app }}" -o name | wc -l) -eq "2" ]]'
       shell: bash
 
     - name: (TPP) Ensure only one pod with the label is present
       run: '[[ $(oc get pods -l "app=${{ inputs.tpp_pod_label_app }}" -o name | wc -l) -eq "1" ]]'
       shell: bash
 
-    - name: (PUT) Discover the name of the test pod
+    - name: (PUT) Discover the name of the first test pod
       run: |
         PUT_POD_NAME=$(oc get pods -l 'app=${{ inputs.put_pod_label_app }}' -o jsonpath='{.items[0].metadata.name}')
         echo "${{ inputs.put_pod_name_env_var }}=$PUT_POD_NAME" >> $GITHUB_ENV

.github/actions/start-minikube/action.yaml

@@ -6,7 +6,7 @@ inputs:
   minikube_driver:
     default: docker
   minikube_extra_options:
-    default: '--embed-certs'
+    default: '--embed-certs --nodes 2'
   oc_kcm_timeout:
     default: 5m
 
@@ -41,6 +41,10 @@ runs:
     - name: Display kube-system pods
       run: oc get pods -n kube-system -o wide
       shell: bash
+      
+    - name: Display cluster nodes
+      run: oc get nodes
+      shell: bash
 
     - name: Display a friendly summary message
       run: echo "TNF-compatible minikube cluster is ready to go! Have fun!"

README.md

@@ -91,12 +91,14 @@ In order to run the local test setup, the following dependencies are needed:
 To start minikube, issue the following command:
 
 ```shell-script
-minikube start --embed-certs --driver="virtualbox"
+minikube start --embed-certs --driver="virtualbox" --nodes 2
 ```
 
 The `--embed-certs` flag will cause minikube to embed certificates directly in its kubeconfig file.  
 This will allow the minikube cluster to be reached directly from the container without the need of binding additional volumes for certificates.
 
+The `--nodes 2` flag creates a cluster with one master node and one worker node. This is to support anti-affinity test cases.
+
 To avoid having to specify this flag, set the `embed-certs` configuration key:
 
 ```shell-script
@@ -120,11 +122,12 @@ To verify `partner` and `test` pods are running:
 oc get pods -n tnf -o wide
 ```
 
-You should see something like this:
+You should see something like this (note that the 2 test pods are running on different nodes due to a anti-affinity rule):
 ```shell-script
-NAME      READY   STATUS    RESTARTS   AGE   IP           NODE       NOMINATED NODE   READINESS GATES
-partner   1/1     Running   0          22m   172.17.0.3   minikube   <none>           <none>
-test      1/1     Running   0          22m   172.17.0.4   minikube   <none>           <none>
+NAME                       READY   STATUS    RESTARTS   AGE    IP           NODE           NOMINATED NODE   READINESS GATES
+partner-68cf756959-tp2c5   1/1     Running   0          110s   10.244.1.7   minikube-m02   <none>           <none>
+test-7799cc9677-6d8qz      1/1     Running   0          110s   10.244.1.8   minikube-m02   <none>           <none>
+test-7799cc9677-rv8nv      1/1     Running   0          110s   10.244.0.5   minikube       <none>           <none>
 ```
 
 To avoid having to specify the `tnf` namespace with the `-n` option, set the namespace for the current context:

local-test-infra/local-pod-under-test.yaml

@@ -5,7 +5,7 @@ metadata:
   name: test
   namespace: tnf
 spec:
-  replicas: 1
+  replicas: 2
   selector:
     matchLabels:
       app: test
@@ -28,3 +28,14 @@ spec:
             limits:
               memory: 512Mi
               cpu: 0.25
+      affinity:
+        podAntiAffinity:
+          requiredDuringSchedulingIgnoredDuringExecution:
+          - labelSelector:
+              matchExpressions:
+              - key: app
+                operator: In
+                values:
+                - test
+            topologyKey: "kubernetes.io/hostname"
+