Adjust replicas if cluster has a single node (#226)

* Adjust replicas if cluster has a single node

* Add new line to the end

---------

Co-authored-by: David Rabkin <[email protected]>

Author: sebrandon1

Makefile

@@ -7,7 +7,7 @@
   install-prometheus
 
 # Deploys the partner and test pods and the operator
-install:
+install: clean
 	./scripts/fix-node-labels.sh
 	./scripts/deploy-multus-network.sh
 	./scripts/deploy-resource-quota.sh

scripts/clean.sh

@@ -18,3 +18,4 @@ source "$SCRIPT_DIR"/init-env.sh
 ./"$SCRIPT_DIR"/delete-limit-range.sh
 ./"$SCRIPT_DIR"/delete-resource-quota.sh
 ./"$SCRIPT_DIR"/delete-pod-disruption-budget.sh
+./"$SCRIPT_DIR"/delete-operator-crd-scaling.sh

scripts/delete-operator-crd-scaling.sh

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+
+SCRIPT_DIR="$(dirname "$0")"
+
+# shellcheck disable=SC1091 # Not following.
+source "$SCRIPT_DIR"/init-env.sh
+REPO_NAME=crd-operator-scaling
+CRD_SCALING_URL=https://github.com/test-network-function/$REPO_NAME.git
+rm -rf $REPO_NAME
+git clone $CRD_SCALING_URL
+## install the operator
+cd $REPO_NAME || exit 1
+## uninstall the crd
+make uninstall
+make undeploy ignore-not-found=true
+rm -rf $REPO_NAME

scripts/deploy-statefulset-test-pods.sh

@@ -8,16 +8,30 @@ source "$SCRIPT_DIR"/init-env.sh
 
 mkdir -p ./temp
 
+REPLICAS=2
+# adjust replicas for possible SNO clusters
+NUM_NODES=$(oc get nodes --no-headers | wc -l)
+if [[ $NUM_NODES == 1 ]]; then
+	REPLICAS=1
+fi
+
 # shellcheck disable=SC2002 # Useless cat.
-cat ./test-target/local-pod-under-test.yaml | APP="testss" RESOURCE_TYPE="StatefulSet" MULTUS_ANNOTATION=$MULTUS_ANNOTATION "$SCRIPT_DIR"/mo > ./temp/rendered-local-statefulset-pod-under-test-template.yaml
+cat ./test-target/local-pod-under-test.yaml | APP="testss" RESOURCE_TYPE="StatefulSet" MULTUS_ANNOTATION=$MULTUS_ANNOTATION REPLICAS=$REPLICAS "$SCRIPT_DIR"/mo > ./temp/rendered-local-statefulset-pod-under-test-template.yaml
 oc apply --filename ./temp/rendered-local-statefulset-pod-under-test-template.yaml
 rm ./temp/rendered-local-statefulset-pod-under-test-template.yaml
 sleep 3
 
 oc wait -l statefulset.kubernetes.io/pod-name=test-0 -n "$TNF_EXAMPLE_CNF_NAMESPACE" --for=condition=ready pod --timeout="$TNF_DEPLOYMENT_TIMEOUT"
-oc wait -l statefulset.kubernetes.io/pod-name=test-1 -n "$TNF_EXAMPLE_CNF_NAMESPACE" --for=condition=ready pod --timeout="$TNF_DEPLOYMENT_TIMEOUT"
 
-# Check for existing HPA first
-if ! oc get hpa test -n "$TNF_EXAMPLE_CNF_NAMESPACE"; then
-	oc autoscale statefulset test -n "$TNF_EXAMPLE_CNF_NAMESPACE" --cpu-percent=50 --min=2 --max=3
+# Wait if there is more than one replica
+if [[ $REPLICAS -gt 1 ]]; then
+	oc wait -l statefulset.kubernetes.io/pod-name=test-1 -n "$TNF_EXAMPLE_CNF_NAMESPACE" --for=condition=ready pod --timeout="$TNF_DEPLOYMENT_TIMEOUT"
+fi
+
+# Only autoscale if there is more than one replica
+if [[ $REPLICAS -gt 1 ]]; then
+	# Check for existing HPA first
+	if ! oc get hpa test -n "$TNF_EXAMPLE_CNF_NAMESPACE"; then
+		oc autoscale statefulset test -n "$TNF_EXAMPLE_CNF_NAMESPACE" --cpu-percent=50 --min=2 --max=3
+	fi
 fi

scripts/deploy-test-pods.sh

@@ -8,8 +8,15 @@ source "$SCRIPT_DIR"/init-env.sh
 
 mkdir -p ./temp
 
+REPLICAS=2
+# adjust replicas for possible SNO clusters
+NUM_NODES=$(oc get nodes --no-headers | wc -l)
+if [[ $NUM_NODES == 1 ]]; then
+    REPLICAS=1
+fi
+
 # shellcheck disable=SC2002 # Useless cat.
-cat ./test-target/local-pod-under-test.yaml | APP="testdp" RESOURCE_TYPE="Deployment" MULTUS_ANNOTATION=$MULTUS_ANNOTATION "$SCRIPT_DIR"/mo > ./temp/rendered-local-pod-under-test-template.yaml
+cat ./test-target/local-pod-under-test.yaml | APP="testdp" RESOURCE_TYPE="Deployment" MULTUS_ANNOTATION=$MULTUS_ANNOTATION REPLICAS=$REPLICAS "$SCRIPT_DIR"/mo > ./temp/rendered-local-pod-under-test-template.yaml
 oc apply --filename ./temp/rendered-local-pod-under-test-template.yaml
 rm ./temp/rendered-local-pod-under-test-template.yaml
 

test-target/local-pod-under-test.yaml

@@ -7,7 +7,7 @@ metadata:
   name: test
   namespace: {{ TNF_EXAMPLE_CNF_NAMESPACE }}
 spec:
-  replicas: 2
+  replicas: {{ REPLICAS }}
   selector:
     matchLabels:
       app: {{ APP }}