Skip to content

Commit e64f9f2

Browse files
authored
Add -trimpath flag and -s -w ldflags on builds (#523)
Signed-off-by: Caleb Xu <[email protected]>
1 parent eb38b9d commit e64f9f2

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,14 @@ K8S_MODULES_MAJOR_VER=$(shell echo $$(($(firstword $(K8S_MODULES_VER)) + 1)))
4343
K8S_MODULES_MINOR_VER=$(word 2,$(K8S_MODULES_VER))
4444

4545
LDFLAGS :=
46+
LDFLAGS += -s -w
4647
LDFLAGS += -X github.com/redhat-certification/chart-verifier/cmd.CommitIDLong=$(COMMIT_ID_LONG)
4748
LDFLAGS += -X github.com/redhat-certification/chart-verifier/internal/chartverifier/checks.defaultMockedKubeVersionString=v$(K8S_MODULES_MAJOR_VER).$(K8S_MODULES_MINOR_VER)
4849

4950
.PHONY: bin
5051
bin:
5152
CGO_ENABLED=0 go build \
53+
-trimpath \
5254
-ldflags '$(LDFLAGS)' \
5355
-o ./out/chart-verifier main.go
5456

@@ -59,7 +61,8 @@ lint: install.golangci-lint
5961
.PHONY: bin_win
6062
bin_win:
6163
env GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go build \
62-
-ldflags "-X 'github.com/redhat-certification/chart-verifier/cmd.CommitIDLong=$(COMMIT_ID_LONG)'" \
64+
-trimpath \
65+
-ldflags "-s -w -X 'github.com/redhat-certification/chart-verifier/cmd.CommitIDLong=$(COMMIT_ID_LONG)'" \
6366
-o .\out\chart-verifier.exe main.go
6467

6568
.PHONY: test

0 commit comments

Comments
 (0)