Skip to content

Commit 4f9fd32

Browse files
committed
Remove un-necessary INGRESSGATEWAY variables.
Using a variable makes the commands longer and doesn't provide any benefit since: 1. the variable name is almost as long as the value. 2. it's only used a single time
1 parent 634b1bb commit 4f9fd32

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

02-basics/bin/call.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#!/bin/bash
22

3-
INGRESSGATEWAY=istio-ingressgateway
4-
IP_ADDRESS="$(minishift ip):$(kubectl get svc $INGRESSGATEWAY --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}')"
3+
IP_ADDRESS="$(minishift ip):$(kubectl get svc istio-ingressgateway --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}')"
54

65
curl -H "Host:greeter.knativetutorial.example.com" $IP_ADDRESS

03-configs-and-routes/bin/call.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
set -e
44

5-
INGRESSGATEWAY=istio-ingressgateway
6-
IP_ADDRESS="$(minishift ip):$(kubectl get svc $INGRESSGATEWAY --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}')"
5+
IP_ADDRESS="$(minishift ip):$(kubectl get svc istio-ingressgateway --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}')"
76

87
while true
98
do

documentation/modules/ROOT/pages/_partials/invoke-service.adoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
[#{k8s-env}-svc-gateway-env]
77
[source,bash,subs="+macros,+attributes"]
88
----
9-
INGRESSGATEWAY=istio-ingressgateway
10-
IP_ADDRESS="$({k8s-env} ip):$({k8s-cli} get svc $INGRESSGATEWAY --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}')"
9+
IP_ADDRESS="$({k8s-env} ip):$({k8s-cli} get svc istio-ingressgateway --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}')"
1110
----
1211
copyToClipboard::{k8s-env}-svc-gateway-env[]
1312

0 commit comments

Comments
 (0)