fix: remove '.html' suffix from license URL (#14)

Author: Enda

spectral/examples/openapi-valid.yaml

@@ -8,7 +8,7 @@ info:
     email: [email protected]
   license:
     name: 'Apache 2.0'
-    url: 'https://www.apache.org/licenses/LICENSE-2.0.html'
+    url: 'https://www.apache.org/licenses/LICENSE-2.0'
 servers:
   - url: https://api.openshift.com
     description: Main (production) server

spectral/ruleset.yaml

@@ -41,7 +41,7 @@ rules:
           - http://localhost:8000
           - "/"
   rhoas-info-license-apache2.0:
-    severity: warn
+    severity: error
     recommended: true
     given: "$"
     then:

spectral/src/functions/infoLicenseApache2.ts

@@ -1,6 +1,6 @@
 import { IFunctionPaths, IFunctionResult } from "@stoplight/spectral";
 
-export default (targetVal: any, opts: any, paths: IFunctionPaths): IFunctionResult[] => {
+export default (targetVal: any, _: any, paths: IFunctionPaths): IFunctionResult[] => {
 	const path = paths.target;
 	if (!targetVal) {
 		return [
@@ -18,8 +18,8 @@ export default (targetVal: any, opts: any, paths: IFunctionPaths): IFunctionResu
 			path: [...path, 'license']
 		})
 	}	
-	const expectUrl = 'https://www.apache.org/licenses/LICENSE-2.0.html'
-	if (targetVal?.url != expectUrl) {
+	const expectUrl = 'https://www.apache.org/licenses/LICENSE-2.0';
+	if (targetVal?.url !== expectUrl) {
 		results.push({
 			message: '`url` must be "' + expectUrl + '"',
 			path: [...path, 'license']