Merge pull request #48 from dimakis/add_more_apis_to_ci

chore: Add more apis to ci

Author: dimakis

.github/workflows/build.yaml

@@ -27,7 +27,6 @@ jobs:
       run: yarn build
     - working-directory: ./spectral
       run: yarn lint
-  # Disabled until we have single API passing tests.
     - working-directory: ./spectral
       run: yarn cli-integration-tests
 

spectral/scripts/rules.sh

@@ -4,10 +4,35 @@
 ## This apis can be used for testing
 ## Script needs to run in the test working directory
 
+spectralConfig="./examples/.spectral-local.yaml"
+baseUrl='https://raw.githubusercontent.com/redhat-developer/app-services-sdk-js/main/.openapi/'
+folder=".openapi"
+file='kas-fleet-manager.yaml'
 
-echo "fetching kas-fleet-manager from main" 
-wget -P .openapi https://raw.githubusercontent.com/redhat-developer/app-services-sdk-js/main/.openapi/kas-fleet-manager.yaml
+wget -P $folder ${baseUrl}${file}
+echo "linting $file OAS file" 
+yarn spectral lint $folder/$file -v -r $spectralConfig
 
-## TODO add more apis
+file='srs-fleet-manager.json'
+wget -P $folder ${baseUrl}${file}
+echo "linting $file OAS file" 
+yarn spectral lint $folder/$file -v -r $spectralConfig
 
-yarn spectral lint .openapi/kas-fleet-manager.yaml -v -r ./examples/.spectral-local.yaml
+## Updates made to the following need to be refected in their respective .openapi OAS files before the linting can pass and added to CI
+
+# file='connector_mgmt.yaml'
+# wget -P $folder ${baseUrl}${file}
+# echo "linting $file OAS file" 
+# yarn spectral lint $folder/$file -v -r $spectralConfig
+
+# file='smartevents.yaml'
+# wget -P $folder ${baseUrl}${file}
+# echo "linting $file OAS file" 
+# yarn spectral lint $folder/$file -v -r $spectralConfig
+
+# file='kafka-admin.yaml'
+# wget -P $folder ${baseUrl}${file}
+# echo "linting $file OAS file" 
+# yarn spectral lint $folder/$file -v -r $spectralConfig
+
+## TODO add more apis as they are onboarded

spectral/src/functions/infoLicenseApache2.ts

@@ -15,20 +15,22 @@ export default (targetVal: any, _: any, context: any): IFunctionResult[] => {
 
 	const results: IFunctionResult[] = [];
 	const expectName = 'Apache 2.0'
-	p = context.path[1];
+	if (context.path[1] != undefined) {
+		p = context.path[1];
+	}
 	if (targetVal?.name != expectName) {
 		results.push({
 			message: '`name` must be "' + expectName + '"',
-			path: [...p, 'license']
+			path: p
 		})
-	}	
+	}
 	const expectUrl = 'https://www.apache.org/licenses/LICENSE-2.0';
 	if (targetVal?.url !== expectUrl) {
 		results.push({
 			message: '`url` must be "' + expectUrl + '" not "' + targetVal?.url + '"',
-			path: [...p, 'license']
+			path: p
 		})
-	}																	
+	}
 
 	return results
 }