Skip to content

Commit 53da137

Browse files
chore: don't eagerly load dependencies (#572)
remove all eager loading as we should never eagerly load any dependency ever; when eagerly loading, the dependency gets bundled with the bundle that will be loaded through module federation, forcing users to download them all over again
1 parent 2e0277f commit 53da137

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

.build/webpack.common.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,17 +129,14 @@ module.exports = (env, argv) => {
129129
shared: {
130130
...dependencies,
131131
react: {
132-
eager: true,
133132
singleton: true,
134133
requiredVersion: dependencies["react"],
135134
},
136135
"react-dom": {
137-
eager: true,
138136
singleton: true,
139137
requiredVersion: dependencies["react-dom"],
140138
},
141139
"@rhoas/app-services-ui-shared": {
142-
eager: true,
143140
singleton: true,
144141
requiredVersion: dependencies["@rhoas/app-services-ui-shared"]
145142
},

0 commit comments

Comments
 (0)