fix: artifact' quickfix should be highlighted with different color

in case it has no issues at all , and has a recommendation

Signed-off-by: Zvi Grinberg <[email protected]>

Author: zvigrinberg

src/main/java/org/jboss/tools/intellij/componentanalysis/CAAnnotator.java

@@ -153,19 +153,18 @@ public void apply(@NotNull PsiFile file, Map<Dependency, Result> annotationResul
 
                         elements.forEach(e -> {
                             if (e != null) {
-                                AnnotationBuilder builder = holder
-                                        .newAnnotation(HighlightSeverity.ERROR, messageBuilder.toString())
-                                        .tooltip(tooltipBuilder.toString())
-                                        .range(e);
-
-                                builder.withFix(new SAIntentionAction());
-
                                 if (!quickfixes.isEmpty() && this.isQuickFixApplicable(e)) {
-                                    quickfixes.forEach((source, report) ->
-                                            builder.withFix(this.createQuickFix(e, source, report)));
+                                    quickfixes.forEach((source, report) ->{
+                                        AnnotationBuilder builder = holder
+                                                .newAnnotation(getHighlightSeverity(report), messageBuilder.toString())
+                                                .tooltip(tooltipBuilder.toString())
+                                                .range(e);
+                                        builder.withFix(new SAIntentionAction());
+                                            builder.withFix(this.createQuickFix(e, source, report));
+                                            builder.create();
+                                      }
+                                    );
                                 }
-
-                                builder.create();
                             }
                         });
                     }
@@ -174,6 +173,19 @@ public void apply(@NotNull PsiFile file, Map<Dependency, Result> annotationResul
         });
     }
 
+    @NotNull
+    private static HighlightSeverity getHighlightSeverity(DependencyReport report) {
+        if(CAIntentionAction.thereAreNoIssues(report) && CAIntentionAction.thereIsRecommendation(report))
+        {
+            return HighlightSeverity.WEAK_WARNING;
+        }
+        else
+        {
+            return HighlightSeverity.ERROR;
+        }
+
+    }
+
     abstract protected String getInspectionShortName();
 
     abstract protected Map<Dependency, List<PsiElement>> getDependencies(PsiFile file);

src/main/java/org/jboss/tools/intellij/componentanalysis/CAIntentionAction.java

@@ -123,11 +123,11 @@ private static boolean thereIsTcRemediation(DependencyReport dependency) {
         }
     }
 
-    private static boolean thereIsRecommendation(DependencyReport dependency) {
+    static boolean thereIsRecommendation(DependencyReport dependency) {
         return dependency.getRecommendation() != null && !dependency.getRecommendation().version().trim().equals("");
     }
 
-    private static boolean thereAreNoIssues(DependencyReport dependency) {
+    static boolean thereAreNoIssues(DependencyReport dependency) {
         return dependency.getIssues() == null || dependency.getIssues().size() == 0;
     }