fix: Fix NPE in LanguageServerWrapper.isSaveSupported

angelozerr · angelozerr · commit b34148b63432 · 2025-11-30T17:54:47.000+01:00
Signed-off-by: azerr &lt;azerr@redhat.com&gt;
diff --git a/src/main/java/com/redhat/devtools/lsp4ij/LanguageServerWrapper.java b/src/main/java/com/redhat/devtools/lsp4ij/LanguageServerWrapper.java
@@ -728,7 +728,10 @@ public boolean isSaveSupported() {
             return false;
         }
         var saveOptions = getSyncOptions().getSave();
-        return saveOptions != null && (saveOptions.isLeft() && saveOptions.getLeft()) || (saveOptions.isRight() && saveOptions.getRight() != null);
+        if (saveOptions == null) {
+            return false;
+        }
+        return (saveOptions.isLeft() && saveOptions.getLeft()) || (saveOptions.isRight() && saveOptions.getRight() != null);
     }
 
     private @NotNull TextDocumentSyncOptions createSyncOptions() {

Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,10 @@ public boolean isSaveSupported() {`
`728`	`728`	`return false;`
`729`	`729`	`}`
`730`	`730`	`var saveOptions = getSyncOptions().getSave();`
`731`		`- return saveOptions != null && (saveOptions.isLeft() && saveOptions.getLeft()) \|\| (saveOptions.isRight() && saveOptions.getRight() != null);`
	`731`	`+ if (saveOptions == null) {`
	`732`	`+ return false;`
	`733`	`+ }`
	`734`	`+ return (saveOptions.isLeft() && saveOptions.getLeft()) \|\| (saveOptions.isRight() && saveOptions.getRight() != null);`
`732`	`735`	`}`
`733`	`736`
`734`	`737`	`private @NotNull TextDocumentSyncOptions createSyncOptions() {`