LSP4IJ 0.4.0 Release

[angelozerr]

Hi,

we are about to release LSP4IJ 0.4.0. Highlights of this release include:

• Support for workspace/symbol
• several bug fixes (for completion, syntax coloration in hover, etc)

More details in the changelog.

Please give a try to the latest nightly build.

Unless you report a blocking issue, we'll proceed with the release next Monday 08/19/2024.

cc @CppCXY @InSyncWithFoo @seachicken @KUGDev @AlexWeinstein92 @aparnamichael @MituuZ @turkeylurkey @mrglavas @koxudaxi @FalsePattern

[fbricon]

We'll actually be releasing on Monday 08/19/2024.

[mrglavas]

@angelozerr @fbricon The most recent nightly build I see in the Marketplace is 0.3.1-20240813-013117. Can I assume this is 0.4.0 for the purpose of testing?

[angelozerr]

Indeed I changed the version to 0.4.0 in my last push but latest nightly build has not be rebuilt.

Once https://github.com/redhat-developer/lsp4ij/actions/runs/10374504784 action will be finished, 0.4.0 should be available.

[angelozerr]

It should be good now

[mrglavas]

When I upgraded to the latest LSP4iJ with our current development stream for Liberty Tools I started seeing this pop-up:

and the following is appearing in trace for MicroProfile:

[Trace - 15:18:17] Received response 'workspace/symbol - (23)' in 2ms.
No result returned.
Error: {
  "code": -32603,
  "message": "Internal error.",
  "data": "java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot invoke \"java.util.List.stream()\" because the return value of \"java.util.concurrent.CompletableFuture.getNow(Object)\" is null\r\n\tat java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)\r\n\tat java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)\r\n\tat java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:649)\r\n\tat java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)\r\n\tat java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147)\r\n\tat org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleResponse(RemoteEndpoint.java:212)\r\n\tat org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:193)\r\n\tat org.eclipse.lsp4mp.ls.commons.ParentProcessWatcher.lambda$apply$0(ParentProcessWatcher.java:148)\r\n\tat org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:194)\r\n\tat org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94)\r\n\tat org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113)\r\n\tat java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)\r\n\tat java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)\r\n\tat java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)\r\n\tat java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)\r\n\tat java.base/java.lang.Thread.run(Thread.java:840)\r\nCaused by: java.lang.NullPointerException: Cannot invoke \"java.util.List.stream()\" because the return value of \"java.util.concurrent.CompletableFuture.getNow(Object)\" is null\r\n\tat org.eclipse.lsp4mp.ls.MicroProfileWorkspaceService.lambda$symbol$3(MicroProfileWorkspaceService.java:105)\r\n\tat java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:273)\r\n\tat java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)\r\n\tat java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)\r\n\tat java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)\r\n\tat java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)\r\n\tat java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)\r\n\tat java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)\r\n\tat org.eclipse.lsp4mp.ls.MicroProfileWorkspaceService.lambda$symbol$4(MicroProfileWorkspaceService.java:107)\r\n\tat java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:646)\r\n\t... 13 more\r\n"
}

Guessing this is related to the new function in 0.4.0 based on the changelog descriptions.

[angelozerr]

@mrglavas I did the fix and support System/Env var (see eclipse-lsp4mp/lsp4mp#448) and the 0.12.0 SNAPSHOT should be available https://download.eclipse.org/justj/?file=lsp4mp/snapshots/0.12.0/repository/plugins, please try it and give us feedback.

[mrglavas]

With the new snapshot I'm not seeing the workspace/symbol error anymore. The trace looks normal.

[mrglavas]

Regarding eclipse-lsp4mp/lsp4mp#448 is this what I should be expecting to see? I had to hover to see the resolved value.

[angelozerr]

LSP4IJ support LSP InlayHint, here the result with IJ Quarkus:

I suspect that you have not activate the Inlay Hint for MicroProfile LS. I suggest you see our IJ Quarkus.

[mrglavas]

I suspect that you have not activate the Inlay Hint for MicroProfile LS. I suggest you see our IJ Quarkus.

@turkeylurkey @aparnamichael We should investigate this. Not sure if we missed integrating something or if this is brand new, but think we should check this out when we synch up LSP4MP4iJ from IJ Quarkus. See OpenLiberty/liberty-tools-intellij#918.

[mrglavas]

This is more a question about user experience... I noticed that there's a "Semantic Tokens Inspector" tab showing up in the IDE. Not sure if this is new for 0.4.0 but I assume this is coming from LSP4iJ. I had to look up what a "Semantic Token" is and still not sure after reading that what these checkbox configuration options do. I do wonder if the average user seeing this tab would understand what it's for and how to use it. Perhaps it needs more explanation somewhere, maybe in the blank space on the right side of the panel?

Can this be hidden if we determine this doesn't apply to anything supported by our plugin?

[angelozerr]

It is afeature from 0.3.0, see https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserGuide.md#semantic-tokens-support

This tab should be hidden by default, no?

[InSyncWithFoo]

This tab should be hidden by default, no?

I don't think so. A bug, maybe?

[mrglavas]

It is afeature from 0.3.0, see https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserGuide.md#semantic-tokens-support

This tab should be hidden by default, no?

We just moved to 0.3.0, which was just an update to our build.gradle to use 0.3.0 from the Marketplace: OpenLiberty/liberty-tools-intellij@8287c40. In my testing I'm updating the value to the latest nightly build so it appears we're getting this by default.

[angelozerr]

This tab should be hidden by default, no?

I don't think so. A bug, maybe?

I did that very quickly, any contribution are welcome to improve it.

[angelozerr]

I dont know how to do that (and no time to investigate that), I created the issue #461 any contribution are welcome!

[angelozerr]

I launched the 0.4.0 release , JetBrains is reviewing it.

[angelozerr]

LSP4IJ 0.4.0 is available at the JetBrains Marketplace https://plugins.jetbrains.com/plugin/23257-lsp4ij/edit/versions/stable/590299

[angelozerr]

@mrglavas please note that we have released yesterday lsp4mp and IJ Quarkus which are now based on LSP4IJ

[turkeylurkey]

Thank you, noted.