Prevent v1 devfiles from being used (#3777)

* Remove leftover v1 devfile check

Signed-off-by: John Collier <John.J.Collier@ibm.com>

* Add integration test

Signed-off-by: John Collier <John.J.Collier@ibm.com>

* Fix typos

Signed-off-by: John Collier <John.J.Collier@ibm.com>

Author: johnmcollier

pkg/devfile/validate/validate.go

@@ -16,7 +16,7 @@ func ValidateDevfileData(data interface{}) error {
 
 	switch d := data.(type) {
 	case *v100.Devfile100:
-		components = d.GetComponents()
+		return fmt.Errorf("unsupported devfile version. Only devfiles with schema version 2.0.0 are supported")
 	case *v200.Devfile200:
 		components = d.GetComponents()
 

tests/integration/devfile/cmd_devfile_push_test.go

@@ -586,6 +586,16 @@ var _ = Describe("odo devfile push command tests", func() {
 			Expect(storageSize).To(ContainSubstring("3Gi"))
 		})
 
+		It("should throw a validation error for v1 devfiles", func() {
+			helper.CmdShouldPass("odo", "create", "java-springboot", "--project", namespace, cmpName)
+
+			helper.CopyExampleDevFile(filepath.Join("source", "devfilesV1", "springboot", "devfile-init.yaml"), filepath.Join(context, "devfile.yaml"))
+
+			// Verify odo push failed
+			output := helper.CmdShouldFail("odo", "push", "--context", context)
+			Expect(output).To(ContainSubstring("unsupported devfile version"))
+		})
+
 	})
 
 	Context("when .gitignore file exists", func() {