Incorporated Fabrice's comments

Author: pabel-rh

modules/authentication/proc-enable-user-authentication-with-gitlab-basic.adoc

@@ -4,8 +4,7 @@
 = Enable user authentication with GitLab
 
 [role="_abstract"]
-Add GitLab to your {product-very-short} deployment
-and use it as an authentication provider.
+Add GitLab to your {product-very-short} deployment and use it as an authentication provider.
 
 .Prerequisites
 include::snip-enable-user-authentication-with-gitlab-common-prerequisites.adoc[]

modules/authentication/snip-enable-user-authentication-with-gitlab-common-first-steps.adoc

@@ -1,28 +1,30 @@
 :_mod-docs-content-type: SNIPPET
 
-. Allow {product-short} to authenticate with GitLab, by creating a GitLab OAuth application.
-.. link:https://docs.gitlab.com/integration/oauth_provider/[Register a GitLab OAuth 2 application] with the following configuration:
+. Register GitLab OAuth 2 application to allow {product-very-short} to authenticate with GitLab with the required callback URL and permissions.
+.. link:https://docs.gitlab.com/integration/oauth_provider/[Register a GitLab OAuth 2 application] using the following configuration:
 
 GitLab OAuth 2 application name::
-Enter a unique name identifying your GitLab OAuth 2 application, such as `authenticating-with-rhdh-__<GUID>__`.
+Enter a unique name, such as `authenticating-with-rhdh-__<GUID>__`.
 
 Redirect URI::
 Enter your {product-short} URL: `pass:c,a,q[{my-product-url}]`.
 
 Authorization callback URL::
-Enter your {product-short} authentication backend URL: `pass:c,a,q[{my-product-url}/api/auth/gitlab/handler/frame]`.
+Enter your authentication backend URL: `pass:c,a,q[{my-product-url}/api/auth/gitlab/handler/frame]`.
 
 Authorized application scope::
 Enable `email`, `profile`, `openid`, and `read_user`.
 
-.. Save the application and note down the following values for the next step:
+.. Save the application and record these values for the next step:
 
 * **OAuth 2 Client ID**, available in the *Application ID* field
 * **OAuth 2 Client secret**, accessible by selecting *Copy* in the *Secret* field
 
-. Add your GitLab credentials to {product-short}
-by adding the following key/value pairs to {configuring-book-link}#provisioning-your-custom-configuration[your {product-short} secrets].
-You can use these secrets in the {product-short} configuration files by using their environment variable name.
+. Add your GitLab credentials to {configuring-book-link}#provisioning-your-custom-configuration[your {product-very-short} secrets] using the following key/value pairs.
+Use these environment variables in your {product-very-short} configuration files.
+
+`GITLAB_HOST`::
+Enter your GitLab host: `<gitlab_host>`.
 
 `GITLAB_CLIENT_ID`::
 Enter the saved **OAuth 2 Client ID**.
@@ -33,7 +35,7 @@ Enter the saved **OAuth 2 Client Secret**.
 `GITLAB_URL`::
 Enter the GitLab host domain: __`<gitlab_host_domain>`__.
 
-`GITLAB_ORG`::
+`GITLAB_PARENT_ORG`::
 Enter your GitLab organization name, such as `__<your_gitlab_organization_name>__`.
 
 . Enable the GitLab catalog provider plugin in your `dynamic-plugins.yaml` file to import GitLab users and groups to the {product-short} software catalog.
@@ -45,7 +47,7 @@ plugins:
     disabled: false
 ----
 
-. Enable provisioning GitLab users and groups to the {product-short} software catalog by adding the GitLab catalog provider section to your `{my-app-config-file}` file:
+. Enable provisioning for GitLab users and groups to the {product-short} software catalog by adding the provider section to your {product-very-short} `{my-app-config-file}` file:
 +
 [source,yaml]
 ----
@@ -68,7 +70,7 @@ catalog:
 ----
 
 `host`::
-Enter your GitLab instance address: `${GITLAB_HOST}`.
+Enter your GitLab instance address: pass:c,a,q[`${GITLAB_HOST}`].
 
 `group`::
 Enter your configured link:https://docs.gitlab.com/user/group/[GitLab parent group]: `${GITLAB_PARENT_ORG}`.
@@ -82,7 +84,7 @@ Enter your schedule timeout, in the ISO duration or "human duration" format.
 `schedule.initialDelay`::
 Enter your schedule initial delay, in the ISO duration or "human duration" format.
 
-. Enable the GitLab authentication provider, by adding the GitLab authentication provider section to your `{my-app-config-file}` file:
+. Enable the GitLab authentication provider by adding the GitLab authentication provider section to your {product-very-short} `{my-app-config-file}` file:
 +
 [source,yaml,subs="+quotes,+attributes"]
 ----