implemented suggestions

Signed-off-by: Fabrice Flore-Thébault <[email protected]>

Author: themr0c

modules/authentication/proc-enabling-authentication-with-github.adoc

@@ -14,19 +14,14 @@ Opt for a GitHub App instead of an OAuth app to use fine-grained permissions, ga
 .. link:https://docs.github.com/en/apps/creating-github-apps/registering-a-github-app/registering-a-github-app[Register a GitHub App] with the following configuration:
 
 GitHub App name::
-Enter a unique name identifying your GitHub App, such as `Authenticating-with-{product-very-short}-__<GUID>__`.
+Enter a unique name identifying your GitHub App, such as `authenticating-with-{product-very-short}-__<GUID>__`.
 
 Homepage URL::
 Enter your {product-short} URL: `pass:c,a,q[{my-product-url}]`.
 
 Authorization callback URL::
 Enter your {product-short} authentication backend URL: `pass:c,a,q[{my-product-url}/api/auth/github/handler/frame]`.
 
-Webhook URL:: Enter your {product-short} URL: `pass:c,a,q[{my-product-url}]`.
-
-Repository permissions::
-Not required.
-
 Organization permissions::
 Enable `Read-only` access to *Members*.
 
@@ -107,14 +102,14 @@ auth:
   providers:
     github:
       production:
-        clientId: ${AUTH_GITHUB_CLIENT_ID}
-        clientSecret: ${AUTH_GITHUB_CLIENT_SECRET}
+        clientId: ${AUTHENTICATION_GITHUB_CLIENT_ID}
+        clientSecret: ${AUTHENTICATION_GITHUB_CLIENT_SECRET}
 signInPage: github
 ----
 +
 `environment: production`::
 Mark the environment as `production` and disable the Guest login option in the {product-short} login page.
-`clientId: ${AUTH_GITHUB_CLIENT_ID}` and `clientSecret: ${AUTH_GITHUB_CLIENT_SECRET}`::
+`clientId: ${AUTHENTICATION_GITHUB_CLIENT_ID}` and `clientSecret: ${AUTHENTICATION_GITHUB_CLIENT_SECRET}`::
 Apply the GitHub credentials configured in your {product-short} secrets.
 `signInPage: github`::
 To enable the GitHub provider as your {product-short} sign-in provider.
@@ -181,8 +176,8 @@ auth:
   providers:
     github:
       production:
-        clientId: ${AUTH_GITHUB_CLIENT_ID}
-        clientSecret: ${AUTH_GITHUB_CLIENT_SECRET}
+        clientId: ${AUTHENTICATION_GITHUB_CLIENT_ID}
+        clientSecret: ${AUTHENTICATION_GITHUB_CLIENT_SECRET}
         signIn:
           resolvers:
             - resolver: usernameMatchingUserEntityName

modules/integrating-with-github/proc-enabling-github-repository-discovery.adoc

@@ -93,7 +93,7 @@ plugins:
     disabled: false
 ----
 
-. To enable GitHub integration with a different authentication provider, add the `catalog.providers.github` and the `integration.github` sections to your custom {product-short} `{my-app-config-file}` configuration file:
+. Configure the GitHub integration, by adding the `catalog.providers.github` and the `integration.github` sections to your custom {product-short} `{my-app-config-file}` configuration file:
 +
 .`{my-app-config-file}` file fragment with mandatory fields to enable GitHub integration
 [source,yaml,subs="+quotes"]