Skip to content

Commit 3b56495

Browse files
committed
Incorporated Jessica's comments
1 parent ed24ff6 commit 3b56495

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

modules/observe/proc-admin-enabling-metrics-ocp-operator.adoc

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ Currently, the {product} Operator does not support creating a `ServiceMonitor` c
2525
apiVersion: monitoring.coreos.com/v1
2626
kind: ServiceMonitor
2727
metadata:
28-
name: <developer-hub-service-monitor-name> <1>
29-
namespace: <rhdh-namespace-name> <2>
28+
name: developer-hub-service-monitor <1>
29+
namespace: {my-product-namespace} <2>
3030
labels:
3131
app.kubernetes.io/instance: <rhdh-cr-name> <3>
3232
app.kubernetes.io/name: {product-custom-resource-type}
@@ -36,22 +36,20 @@ spec:
3636
- <rhdh-namespace-name> <4>
3737
selector:
3838
matchLabels:
39-
app.kubernetes.io/instance: <deployment-name> <5>
40-
app.kubernetes.io/name: <rhdh-cr-type> <6>
39+
app.kubernetes.io/instance: developer-hub <4>
40+
app.kubernetes.io/name: {product-custom-resource-type}
4141
endpoints:
4242
- port: http-metrics
4343
path: '/metrics'
4444
----
45-
<1> The name of your `ServiceMonitor` resource, for example, `developer-hub-service-monitor`.
46-
<2> The namespace where your `ServiceMonitor` will live, for example, `{my-product-namespace}`.
47-
<3> The label name identifying the `ServiceMonitor` CR instance, for example, `{my-product-cr-name}`.
48-
<4> The namespace where your {product-very-short} instance is installed, for example, `{my-product-namespace}`.
49-
<5> The name of your {product-very-short} deployment, for example, `developer-hub`.
50-
<6> The name of your {product-very-short} application, for example, `backstage`.
51-
+
45+
<1> The name of your ServiceMonitor resource, for example, `developer-hub-service-monitor`.
46+
<2> The namespace where your ServiceMonitor lives and where your {product-very-short} instance is installed.
47+
<3> The name of the {ocp-short} project where your {product} instance is running.
48+
<4> The name of your {product-very-short} deployment.
5249
[NOTE]
50+
+
5351
====
54-
`spec.selector.matchLabels` configuration must match the labels of your {product-very-short} installation.
52+
`spec.selector.matchLabels` configuration must match the labels of your {product-very-short} installation. To confirm the label names, go to Project > Services and get the labels for `backstage-developer-hub`.
5553
====
5654

5755
. Apply the `ServiceMonitor` CR by running the following command:

0 commit comments

Comments
 (0)