Skip to content

Commit 4216b1f

Browse files
committed
Incorporated Dominika's comments and added images
1 parent 846a104 commit 4216b1f

7 files changed

+15
-7
lines changed
107 KB
Loading

images/rhdh/scorecard-sample.png

102 KB
Loading

modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ Order the rules from the most restrictive value range to the least restrictive t
2424
----
2525
# Correct Example: Order from most restrictive (Error) to least restrictive (Success)
2626
rules:
27-
- key: error
28-
expression: '<10' # Only values below 10
29-
- key: warning
30-
expression: '10-50' # Only values between 10 and 50
3127
- key: success
3228
expression: '>50' # All remaining values above 50
29+
- key: warning
30+
expression: '10-50' # Only values between 10 and 50
31+
- key: error
32+
expression: '<10' # Only values below 10
3333
----

modules/observe/scorecards/con-understand-scorecard-plugins.adoc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,6 @@
55

66
include::{docdir}/artifacts/snip-developer-preview.adoc[]
77

8-
The Scorecard plugin offers comprehensive, customizable insights into the health, security posture, and compliance of your components, services, and APIs. It centralizes Key Performance Indicators (KPIs) within {product} ({product-very-short}), so you do not have to consult multiple external systems.
8+
The Scorecard plugin offers comprehensive, customizable insights into the health, security posture, and compliance of your components, services, and APIs. It centralizes Key Performance Indicators (KPIs) within {product} ({product-very-short}), so you do not have to consult multiple external systems.
9+
10+
image::rhdh/scorecard-sample.png[]

modules/observe/scorecards/proc-authenticating-and-managing-scorecard-plugins.adoc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,6 @@ See {authorization-book-link}#ref-rbac-permission-policies_title-authorization[P
2323
... To enable read access for the Scorecard plugin, add a policy with the following details and click *Next*:
2424
**** *Permission*: `scorecard.metric.read`
2525
**** *Action*: `read`
26-
**** *Effect*: `allow`
26+
**** *Effect*: `allow`
27+
28+
image::rhdh/scorecard-create-role.png[]

modules/observe/scorecards/proc-configuring-github-scorecards-in-rhdh-instance.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ scorecard:
102102
expression: '>50'
103103
----
104104
+
105-
`scorecard:plugins:github:open_prs:threshold`:: Lists the default threshold values for the GitHub metrics.
105+
`scorecard:plugins:github:open_prs:thresholds`:: Lists the default threshold values for the GitHub open PRs metric.
106106

107107
[NOTE]
108108
====

modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,10 @@ scorecard:
128128
- key: error
129129
expression: '>50'
130130
----
131+
where
132+
133+
`scorecard:plugins:jira:open_issues:thresholds`:: Lists the default threshold values for the Jira open Issues metric.
134+
131135
. (Optional) Define global or custom mandatory filters.
132136
.. You can apply global mandatory filters or define custom filters that entities can override. Add the following to your `{product-very-short} app-config.yaml`:
133137
+

0 commit comments

Comments
 (0)