Skip to content

Commit 5067b35

Browse files
themr0chmanwani-rh
andauthored
Apply suggestions from code review
Co-authored-by: Heena Manwani <[email protected]>
1 parent 097365b commit 5067b35

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

modules/importing-repositories/procedure-importing-multiple-repositories-from-github.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@ This option allows you to select one or more repositories from the selected orga
2121
. Click *Create pull requests*.
2222
At this point, a set of dry-run checks runs against the selected repositories to ensure they meet the requirements for import, such as:
2323
.. Verifying that there is no entity in the {product-short} catalog with the name specified in the repository `catalog-info.yaml`
24-
.. Checking that the repository is not empty
25-
.. Verifying that the repository contains a `.github/CODEOWNERS` file if the *Use CODEOWNERS file as Entity Owner* checkbox is selected for that repository.
24+
.. Verifying that the repository is not empty
25+
.. Verifying that the repository contains a `.github/CODEOWNERS` file if the *Use CODEOWNERS file as Entity Owner* checkbox is selected for that repository
2626

27-
** If any errors occur, the pull requests are not created, and you will see a _Failed to create PR_ error message detailing the issues.
27+
** If any errors occur, the pull requests are not created, and you see a _Failed to create PR_ error message detailing the issues.
2828
To view more details about the reasons, click *Edit*.
2929

30-
** If there are no errors, the pull requests are created, and you will be redirected to the list of added repositories.
30+
** If there are no errors, the pull requests are created, and you are redirected to the list of added repositories.
3131

3232
. Review and merge each pull request that creates a `catalog-info.yml` file.
3333

3434
.Verification
35-
* The *Added repositories* list displays the repositories you just imported, each with an appropriate status: either _Waiting for approval_ or _Added_.
36-
* For each _Waiting for approval_ import job listed, there is a corresponding pull request adding the `catalog-info.yaml` file in the corresponding repository
35+
* The *Added repositories* list displays the repositories you imported, each with an appropriate status: either _Waiting for approval_ or _Added_.
36+
* For each _Waiting for approval_ import job listed, there is a corresponding pull request adding the `catalog-info.yaml` file in the corresponding repository.
3737

modules/importing-repositories/procedure-managing-the-imported-repository-list.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[id="managing-the-added-repositories]
22
= Managing the added repositories
3-
3+
You can oversee and manage the repositories that are imported to the {product-short}.
44
.Prerequisites
55
* You have xref:importing-multiple-github-repositories[imported GitHub repositories].
66

@@ -15,7 +15,7 @@ Note that it may take a few minutes for the entities to be available in the cata
1515
Waiting for approval:: There is an open pull request adding a `catalog-info.yaml` file to the repository.
1616
You can:
1717
* Click the *pencil icon* on the right to see details about the pull request or edit the pull request content right from {product-short}.
18-
* Delete the Import job, this closes the import PR as well.
18+
* Delete the Import job, this action closes the import PR as well.
1919
* To transition the Import job to the _Added_ state, merge the import pull request from the Git repository.
2020

2121
Empty:: {product-short} is unable to determine the import job status because the repository is imported from other sources but does not have a `catalog-info.yaml` file and lacks any import pull request adding it.
@@ -24,7 +24,7 @@ This can be the case if the repository was imported from other sources but does
2424
[NOTE]
2525
====
2626
* After an import pull request is merged, the import status is marked as _Added_ in the list of Added Repositories, but it might take a few seconds for the corresponding entities to appear in the {product-short} Catalog.
27-
* A location added through other sources (like statically in an `app-config.yaml` file, dynamically when link:{linkgettingstartedguide}#enabling-github-discovery-in-red-hat-developer-hub[enabling GitHub discovery], or registered manually using the "Register an existing component" page) may show up in the Bulk Import list of Added Repositories if the following conditions are met:
27+
* A location added through other sources (like statically in an `app-config.yaml` file, dynamically when link:{linkgettingstartedguide}#enabling-github-discovery-in-red-hat-developer-hub[enabling GitHub discovery], or registered manually using the "Register an existing component" page) might show up in the Bulk Import list of Added Repositories if the following conditions are met:
2828
** The target repository is accessible from the configured GitHub integrations.
2929
** The location URL points to a `catalog-info.yaml` file at the root of the repository default branch.
3030
====

modules/importing-repositories/procedure-understanding-bulk-import-audit-logs.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
= Understanding the Bulk Import audit Logs
33

44
The Bulk Import backend plugin adds the following events to the {product-short} audit logs.
5-
See link:{linkgettingstartedguide}#assembly-audit-log[Audit Logs in {product}] for more information on how to configure and view such audit logs.
5+
See link:{linkgettingstartedguide}#assembly-audit-log[Audit Logs in {product}] for more information on how to configure and view audit logs.
66

77
*Bulk Import Events*:
88

0 commit comments

Comments
 (0)