Skip to content

Commit 700bd13

Browse files
authored
Apply suggestions from code review
use attributes
1 parent 09fda0f commit 700bd13

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

modules/installation/proc-deploy-rhdh-instance-eks.adoc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ data:
4444
----
4545
--
4646

47-
. Create a Secret named `my-rhdh-secrets` and add a key named `BACKEND_SECRET` with a `Base64-encoded` string as value:
47+
. Create a Secret named `{my-product-secrets}` and add a key named `BACKEND_SECRET` with a `Base64-encoded` string as value:
4848
+
4949
--
50-
[source,yaml]
50+
[source,yaml,subs="+attributes,+quotes"]
5151
----
5252
apiVersion: v1
5353
kind: Secret
5454
metadata:
55-
name: my-rhdh-secrets
55+
name: {my-product-secrets}
5656
stringData:
5757
# TODO: See https://backstage.io/docs/auth/service-to-service-auth/#setup
5858
BACKEND_SECRET: "xxx"
@@ -85,7 +85,7 @@ kubectl patch serviceaccount default \
8585
. Create a Custom Resource file using the following template:
8686
+
8787
--
88-
[source,yaml,subs="attributes+"]
88+
[source,yaml,subs="+attributes,+quotes"]
8989
----
9090
apiVersion: rhdh.redhat.com/v1alpha3
9191
kind: Backstage
@@ -103,7 +103,7 @@ spec:
103103
- name: "app-config-rhdh"
104104
extraEnvs:
105105
secrets:
106-
- name: "my-rhdh-secrets"
106+
- name: {my-product-secrets}
107107
----
108108
--
109109

0 commit comments

Comments
 (0)