Skip to content

Commit 8d40f2f

Browse files
committed
Incorporated Fabrice's comments
1 parent a8c18b9 commit 8d40f2f

File tree

4 files changed

+23
-21
lines changed

4 files changed

+23
-21
lines changed

assemblies/assembly-enable-authentication.adoc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,12 @@ include::assembly-enable-authentication-with-github.adoc[leveloffset=+1]
2222

2323
include::assembly-enable-authentication-with-azure.adoc[leveloffset=+1]
2424

25+
include::assembly-enable-authentication-with-gitlab-basic.adoc[leveloffset=+1]
2526

2627
include::assembly-enable-service-to-service-authentication.adoc[leveloffset=+1]
2728

2829

2930
include::modules/authentication/proc-enable-auto-logout-for-inactive-users.adoc[leveloffset=+1]
3031

3132

32-
include::assembly-troubleshoot-authentication-issues.adoc[leveloffset=+1]
33-
34-
//Including this here as I'm not sure how Jana would like the new title to be for the GitLab title. This will be done in RHDHBUGS-2640
35-
include::assembly-enable-authentication-with-gitlab-basic.adoc[leveloffset=+1]
33+
include::assembly-troubleshoot-authentication-issues.adoc[leveloffset=+1]

modules/authentication/proc-enable-user-authentication-with-gitlab-basic.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
= Enable user authentication with GitLab
55

66
[role="_abstract"]
7-
Add GitLab to your {product-very-short} deployment and use it as an authentication provider.
7+
You can enable authentication with GitLab to allow users to sign in to {product-short} using their GitLab credentials. This integration also allows you to provision user and group data from GitLab to the {product-short} software catalog, enabling features that rely on synchronized user and group data.
88

99
.Prerequisites
1010
include::snip-enable-user-authentication-with-gitlab-common-prerequisites.adoc[]

modules/authentication/snip-enable-user-authentication-with-gitlab-common-first-steps.adoc

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ Enable `email`, `profile`, `openid`, and `read_user`.
2121
* **OAuth 2 Client ID**, available in the *Application ID* field
2222
* **OAuth 2 Client secret**, accessible by selecting *Copy* in the *Secret* field
2323
24-
. Create a link:https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html[GitLab personal access token] with the `read_api` scope. Save this token to use in your OpenShift secret.
25-
2624
. Add your GitLab credentials to {configuring-book-link}#provisioning-your-custom-configuration[your {product-very-short} secrets] using the following key/value pairs.
2725
Use these environment variables in your {product-very-short} configuration files.
2826

@@ -35,24 +33,13 @@ Enter the saved *OAuth 2 Client ID*.
3533
`GITLAB_CLIENT_SECRET`::
3634
Enter the saved *OAuth 2 Client Secret*.
3735

38-
`GITLAB_TOKEN`::
39-
Enter your *GitLab personal access token*.
40-
4136
`GITLAB_URL`::
4237
Enter the GitLab host domain: _`<gitlab_host_domain>`_.
4338

4439
`GITLAB_PARENT_ORG`::
4540
Enter your GitLab organization name, such as `_<your_gitlab_organization_name>_`.
4641

47-
. Configure the GitLab integration by adding the following section to your {product-very-short} `{my-app-config-file}` file:
48-
+
49-
[source,yaml,subs="+quotes,+attributes"]
50-
----
51-
integrations:
52-
gitlab:
53-
- host: $\{GITLAB_HOST}
54-
token: $\{GITLAB_TOKEN}
55-
----
42+
. {integrating-with-github-book-link}##importing-multiple-repositories-from-gitlab[Configure the GitLab integration].
5643

5744
. Enable the GitLab catalog provider plugin in your `dynamic-plugins.yaml` file to import GitLab users and groups to the {product-short} software catalog.
5845
+

modules/importing-repositories/proc-importing-multiple-repositories-from-gitlab.adoc

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,31 @@ See: link:https://access.redhat.com/support/offerings/techpreview/[Technology Pr
1717
.Prerequisites
1818
* You have {configuring-dynamic-plugins-book-link}#bulk-importing-github-repositories[enabled the Bulk Import feature and given access to it].
1919
* You have set up a link:https://docs.gitlab.com/user/profile/personal_access_tokens/[GitLab personal access token (PAT)].
20+
* You configured the GitLab integration by adding the following section to your {product-very-short} `{my-app-config-file}` file:
21+
+
22+
[source,yaml,subs="+quotes,+attributes"]
23+
----
24+
integrations:
25+
gitlab:
26+
- host: ${GITLAB_HOST}
27+
token: ${GITLAB_TOKEN}
28+
----
29+
* You enabled the GitLab catalog provider plugin in your `dynamic-plugins.yaml` file to import GitLab users and groups:
30+
+
31+
[source,yaml]
32+
----
33+
plugins:
34+
- package: './dynamic-plugins/dist/backstage-plugin-catalog-backend-module-gitlab-org-dynamic'
35+
disabled: false
36+
----
2037

2138
.Procedure
22-
. Click *Bulk Import* in {product-short} left sidebar.
39+
. In the {product-short} left sidebar, click *Bulk Import*.
2340
. If your {product-very-short} instance has multiple source control tools configured, select GitLab as your *Source control tool* option.
2441
. Select the projects to import, and validate.
2542
+
2643
{product-short} creates a merge request in each selected project to add the required `catalog-info.yaml` file.
27-
. For each project to import, click on the *PR* link to review and merge the changes in Gitlab.
44+
. For each project to import, click the *PR* link to review and merge the changes in Gitlab.
2845

2946
.Verification
3047
. Click *Bulk Import* in {product-short} left sidebar.

0 commit comments

Comments
 (0)