Skip to content

Commit b15aeec

Browse files
committed
Incorporated Lindsey's comments
1 parent f55340c commit b15aeec

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

modules/observe/proc-admin-enabling-metrics-ocp-operator.adoc

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,32 +25,33 @@ Currently, the {product} Operator does not support creating a `ServiceMonitor` c
2525
apiVersion: monitoring.coreos.com/v1
2626
kind: ServiceMonitor
2727
metadata:
28-
name: developer-hub-service-monitor <1>
29-
namespace: {my-product-namespace} <2>
28+
name: <developer-hub-service-monitor-name> <1>
29+
namespace: <rhdh-namespace-name> <2>
3030
labels:
3131
app.kubernetes.io/instance: <rhdh-cr-name> <3>
3232
app.kubernetes.io/name: {product-custom-resource-type}
3333
spec:
3434
namespaceSelector:
3535
matchNames:
36-
- {my-product-namespace} <4>
36+
- <rhdh-namespace-name> <4>
3737
selector:
3838
matchLabels:
39-
app.kubernetes.io/instance: developer-hub <5>
40-
app.kubernetes.io/name: {product-custom-resource-type}
39+
app.kubernetes.io/instance: <deployment-name> <5>
40+
app.kubernetes.io/name: <rhdh-cr-type> <6>
4141
endpoints:
4242
- port: http-metrics
4343
path: '/metrics'
4444
----
4545
<1> The name of your `ServiceMonitor` resource, for example, `developer-hub-service-monitor`.
46-
<2> The namespace where your `ServiceMonitor` will live.
47-
<3> The label name identifying the `ServiceMonitor` CR instance.
48-
<4> The namespace where your {product-very-short} instance is installed.
49-
<5> The name of your {product-very-short} deployment.
50-
[NOTE]
46+
<2> The namespace where your `ServiceMonitor` will live, for example, `{my-product-namespace}`.
47+
<3> The label name identifying the `ServiceMonitor` CR instance, for example, `{my-product-cr-name}`.
48+
<4> The namespace where your {product-very-short} instance is installed, for example, `{my-product-namespace}`.
49+
<5> The name of your {product-very-short} deployment, for example, `developer-hub`.
50+
<6> The type of custom resource that you want to use, for example, `{product-custom-resource-type}`.
5151
+
52+
[NOTE]
5253
====
53-
`spec.selector.matchLabels` configuration must match the labels of your {product-very-short} installation. To confirm the label names, go to Project > Services and verify the labels for `backstage-developer-hub`.
54+
`spec.selector.matchLabels` configuration must match the labels of your {product-very-short} installation.
5455
====
5556

5657
. Apply the `ServiceMonitor` CR by running the following command:
@@ -64,4 +65,4 @@ oc apply -f <filename>
6465

6566
. From the *Developer* perspective in the {ocp-short} web console, select the *Observe* view.
6667
. Click the *Metrics* tab to view metrics for {product} pods.
67-
. From the OpenShift Console in the Developer view, click **Project > Services** and verify the labels for `backstage-developer-hub`.
68+
. From the OpenShift Console in the Developer view, click **Project > Services** and verify the labels for `backstage-developer-hub`.

0 commit comments

Comments
 (0)