Skip to content

Commit b379a2f

Browse files
committed
Dominika's comments
1 parent ea0f934 commit b379a2f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ Order the rules from the most restrictive value range to the least restrictive t
2222
+
2323
[source,yaml]
2424
----
25-
# Correct Example: Order from most restrictive (Error) to least restrictive (Success)
25+
# Correct Example: Order from most restrictive (Success) to least restrictive (Error)
2626
rules:
2727
- key: success
28-
expression: '>50' # All remaining values above 50
28+
expression: '<10' # Only values below 15
2929
- key: warning
3030
expression: '10-50' # Only values between 10 and 50
3131
- key: error
32-
expression: '<10' # Only values below 10
32+
expression: '>50' # All remaining values above 50
3333
----

modules/observe/scorecards/con-set-global-standards-for-metric-thresholds.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
To override the default thresholds set by a metric provider, you must update your `{product-very-short} app-config.yaml` file under the configuration path of the specific metric.
77

8-
The custom configuration completely replaces the provider's defaults. If you omit a threshold category (such as `success`), that category is not assigned unless it is explicitly overridden later by an entity annotation in the `catalog-info.yaml` file.
8+
The custom configuration completely replaces the provider's defaults. If you omit a threshold category (such as `success`), that category is not assigned.
99

1010
The following configuration defines a `success` threshold as 10 or fewer issues, which applies to all components using the `jira.open_issues` metric unless explicitly overridden by an entity annotation.
1111
+

modules/observe/scorecards/proc-authenticating-and-managing-scorecard-plugins.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ p, role:default/scorecard-viewer, catalog.entity.read, read, allow
1818
See {authorization-book-link}#ref-rbac-permission-policies_title-authorization[Permission policies reference].
1919

2020
** To use the RBAC Web UI, complete the following steps:
21-
... In your {product} menu, go to *Settings > RBAC*.
21+
... In your {product} menu, go to *Administration > RBAC*.
2222
... Select or create the *Role* to which you want to grant access to the Scorecards.
2323
... To enable read access for the Scorecard plugin, add a policy with the following details and click *Next*:
2424
**** *Permission*: `scorecard.metric.read`

0 commit comments

Comments
 (0)