Skip to content

Commit b97eb0c

Browse files
committed
RHIDP-7038: Apply Tech Review comments
1 parent e9a2d5f commit b97eb0c

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

modules/installation/proc-install-rhdh-airgapped-full-k8s-helm.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ helm pull _<helm_chart_repo_name>_/redhat-developer-hub --version _<rhdh_version
2626
where
2727

2828
_<helm_chart_repo_name>_ :: Specifies the name of the Helm chart repository, for example, `openshift-helm-charts`.
29-
_<rhdh_version>_ :: Specifies the {product} version that you want to use, for example, `1.4.0`.
29+
_<rhdh_version>_ :: Specifies the {product} version that you want to use, for example, `{product-chart-version}`.
3030
+
3131
[NOTE]
3232
====
@@ -55,9 +55,9 @@ skopeo copy --all docker://${PG_IMAGE}:${PG_DIGEST} dir:./postgresql
5555
+
5656
* rhdh-hub
5757
* postgresql
58-
* Helm chart archive file, for example, `redhat-developer-hub-1.4.0.tgz`
58+
* Helm chart archive file, for example, `redhat-developer-hub-{product-chart-version}.tgz`
5959
+
60-
. Load the images onto the air-gapped host by running the following command:
60+
. Load the images onto the air-gapped host by running the following commands:
6161
+
6262
[source,terminal,subs="+quotes"]
6363
----

modules/installation/proc-install-rhdh-airgapped-partial-k8s-helm.adoc

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ In a partially disconnected environment, the cluster cannot access external regi
2121
helm repo add _<helm_chart_repo_name>_ https://charts.openshift.io/
2222
helm repo update
2323
helm pull _<helm_chart_repo_name>_/redhat-developer-hub --version _<rhdh_version>_
24-
helm show values _<helm_chart_repo_name>_/redhat-developer-hub --version _<rhdh_version>_ values.default.yaml
24+
helm show values _<helm_chart_repo_name>_/redhat-developer-hub --version _<rhdh_version>_ > values.default.yaml
2525
----
2626
+
2727
where
2828

2929
_<helm_chart_repo_name>_ :: Specifies the name of the Helm chart repository, for example, `openshift-helm-charts`.
30-
_<rhdh_version>_ :: Specifies the {product} version that you want to use, for example, `1.4.0`.
30+
_<rhdh_version>_ :: Specifies the {product} version that you want to use, for example, `{product-chart-version}`.
3131
+
3232
. Use `yq` to extract the image digests by running the following commands:
3333
+
@@ -206,5 +206,9 @@ upstream:
206206
+
207207
[source,terminal,subs="attributes+"]
208208
----
209-
helm install rhdh ./redhat-developer-hub-1.4.0.tgz -f values.yaml
209+
helm install rhdh ./_<helm_chart_archive_file_name>_ -f values.yaml
210210
----
211+
+
212+
where
213+
214+
_<helm_chart_archive_file_name>_ :: Specifies the name of the Helm chart archive file, for example, `redhat-developer-hub-{product-chart-version}.tgz`.

0 commit comments

Comments
 (0)