Skip to content

Commit f7272e5

Browse files
committed
fix erroneous procedure
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
1 parent fdb3c14 commit f7272e5

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

modules/authentication/proc-enabling-authentication-with-github.adoc

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,27 @@ auth:
159159
enterpriseInstanceUrl: ${GITHUB_HOST_DOMAIN}
160160
----
161161

162+
[TIP]
163+
====
164+
To enable GitHub integration with another authentication provider you have already configured, omit the `auth` and `signInPage` sections from this procedure:
165+
166+
.`app-config-rhdh.yaml` fragment with mandatory fields to enable integration with GitHub and use a different authentication provider
167+
[source,yaml]
168+
----
169+
integrations:
170+
github:
171+
- host: ${GITHUB_HOST_DOMAIN}
172+
apps:
173+
- appId: ${AUTH_GITHUB_APP_ID}
174+
clientId: ${AUTH_GITHUB_CLIENT_ID}
175+
clientSecret: ${GITHUB_CLIENT_SECRET}
176+
webhookUrl: ${GITHUB_WEBHOOK_URL}
177+
webhookSecret: ${GITHUB_WEBHOOK_SECRET}
178+
privateKey: |
179+
${GITHUB_PRIVATE_KEY_FILE}
180+
----
181+
====
182+
162183
--
163184

164185
.Verification

modules/importing-repositories/procedure-enabling-the-bulk-import-from-github-feature.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
You can enable the Bulk Import feature for users and give them the necessary permissions to access it.
44

55
.Prerequisites
6-
* You have link:{authentication-book-url}#enabling-authentication-with-github[configured GitHub authentication and integration].
6+
* You have link:{authentication-book-url}#enabling-authentication-with-github[configured GitHub integration].
77

88
.Procedure
99

0 commit comments

Comments
 (0)