Skip to content

RHDHPAI-810: New home cards #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagak merged 2 commits into from
Jun 16, 2025
Merged

RHDHPAI-810: New home cards #1222

jmagak merged 2 commits into from
Jun 16, 2025

Conversation

@pabel-rh
Copy link
Member

@pabel-rh pabel-rh commented Jun 10, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
main (and 1.7)
Issue:
RHDHPAI-810
Preview:

@pabel-rh pabel-rh requested a review from Eswaraiahsapram June 10, 2025 10:54
@jmagak
Copy link
Member

jmagak commented Jun 10, 2025

Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1222/

Eswaraiahsapram
Eswaraiahsapram approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@Eswaraiahsapram Eswaraiahsapram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 11, 2025
jmagak
jmagak reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little suggestion, otherwise, LGTM. @pabel-rh

@openshift-ci openshift-ci bot removed the lgtm label Jun 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

New changes are detected. LGTM label has been removed.

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 11, 2025

Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1222/

@jmagak
Copy link
Member

jmagak commented Jun 16, 2025

/cherry-pick release-1.7

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Jun 16, 2025

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit b99affa into redhat-developer:main Jun 16, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Jun 16, 2025

@jmagak: cannot checkout release-1.7: error checking out "release-1.7": exit status 1 error: pathspec 'release-1.7' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagak jmagak jmagak approved these changes

+1 more reviewer

@Eswaraiahsapram Eswaraiahsapram Eswaraiahsapram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Eswaraiahsapram Eswaraiahsapram

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pabel-rh @jmagak @rhdh-bot @openshift-cherrypick-robot @Eswaraiahsapram