Skip to content

Conversation

jmagak
Copy link
Member

@jmagak jmagak commented Oct 15, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Oct 15, 2025

@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from 84a6b2b to 335d353 Compare October 15, 2025 23:25
@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from 115f07b to 6e66f13 Compare October 16, 2025 14:59
@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Oct 17, 2025

Hello!
Sorry, but the file 'procedure-data-handoff-and-custom-workflow-design.adoc' gives me a strong impression that the scaffolder author is expected to handle an array of repositories inside the template.

I prepared some proposals that clarify that the bulk import feature does not pass an array of repositories to a single template run. Instead, it launches the same scaffolder template once per repository.

We already have an example of such a scaffolder template here:
https://github.com/redhat-developer/rhdh-plugins/blob/main/workspaces/bulk-import/examples/template/create-pr-with-catalog-info.yaml

(It may look a bit complex because it is designed to handle two Git providers: GitHub and GitLab.)

@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from 974f48c to 4412885 Compare October 17, 2025 14:34
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jmagak jmagak added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Oct 20, 2025
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments

@jmagak jmagak force-pushed the RHIDP-8632-Update-the-Bulk-Import-Plugin-to-Integrate-with-Existing-Backstage-Templates-and-Orchestrator-Workflows branch from de49fda to 2d262b6 Compare October 21, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants