-
Notifications
You must be signed in to change notification settings - Fork 55
RHIDP-8828: Injecting resources for backstage containers #1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1464/ @ 10/31/25 15:44:06 |
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/con-mounting-and-container-targeting-details.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/con-mounting-and-container-targeting-details.adoc
Outdated
Show resolved
Hide resolved
modules/configuring/con-mounting-and-container-targeting-details.adoc
Outdated
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, @pabel-rh.
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed, here's my feedback
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
| extraFiles: | ||
| mountPath: /my/path | ||
| configMaps: | ||
| - name: cm1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume names such as file21.txt are user replaceable values. they need to be formatted as such. these rules are for both for file names and paths: https://redhat-documentation.github.io/supplementary-style-guide/#user-replaced-values
I'm not sure if cm1 etc. is user replaceable or not. I'd double-check with the SME
I'd change the names to something like <first_config_map_name>, <first_secret_name>, and <first_file_name> (followed by second secret name, third configmap name etc.)
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
| `spec.application.secrets.configMaps.containers`:: Injects all keys from secret1 | ||
| `spec.application.envs.containers`:: Targets only this container. | ||
|
|
||
| The following explicit options are supported: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be an admonition
...iguring/proc-injecting-custom-files-and-environment-variables-into-backstage-containers.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| [cols="1,2,3,2", options="header"] | ||
| |=== | ||
| | Resource | Target type | Path(s) or name(s) | Container(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is tricky because the contents are from a specific example. I'd add a title again Example (...)::
I assume /my/path/file11.txt, /my/path/file12.txt etc. are user replaceable values. we have two options, I think: either include the example input from the procedure above (include it as is, with the file names and paths) or format the user replaceable values according to the Red Hat style guide. I suggest you reach out to Gerry or Fabrice for a second opinion.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
1.8.0, main
Issue:
RHIDP-8828
Preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1464/configuring/#proc-injecting-custom-files-and-environment-variables-into-backstage-containers