Skip to content

RHIDP-9646: Modularization for the new content #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

RHIDP-9646: Modularization for the new content #1596

merged 1 commit into from
Nov 28, 2025

Conversation

@pabel-rh
Copy link
Member

@pabel-rh pabel-rh commented Nov 25, 2025 •
edited
Loading

@pabel-rh pabel-rh requested a review from themr0c November 25, 2025 09:34
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 25, 2025

Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1596/

@deerskindoll
Copy link
Contributor

deerskindoll commented Nov 26, 2025

@pabel-rh everything looks fine but I'm struggling with locating the preview of the updated docs. can you please share the link? I want to check if all user-replaceable values are marked correctly.

@deerskindoll deerskindoll self-requested a review November 26, 2025 22:41
@pabel-rh
Copy link
Member Author

pabel-rh commented Nov 27, 2025

I've included the preview links, @deerskindoll . I'm sorry for not adding them earlier.

deerskindoll
deerskindoll approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small tweaks, otherwise lgtm

@jmagak
Copy link
Member

jmagak commented Nov 28, 2025

/cherry-pick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 28, 2025

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit fd182d2 into redhat-developer:main Nov 28, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Nov 28, 2025

@jmagak: new pull request created: #1611

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagak jmagak jmagak approved these changes

@themr0c themr0c Awaiting requested review from themr0c

@deerskindoll deerskindoll Awaiting requested review from deerskindoll

Assignees

No one assigned

Labels

Peer review done 📘 Ready to merge 💂

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pabel-rh @rhdh-bot @deerskindoll @jmagak @openshift-cherrypick-robot