Skip to content

Updated plugin doc for Argo CD Rollouts feature #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagak merged 2 commits into from
Feb 27, 2025
Merged

Updated plugin doc for Argo CD Rollouts feature #725

jmagak merged 2 commits into from
Feb 27, 2025

Conversation

@gtrivedi88
Copy link
Contributor

@gtrivedi88 gtrivedi88 commented Nov 21, 2024 •
edited by jmagak
Loading

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

In this PR:

  • I added content for the Argo CD Rollouts feature

Version(s): RHDH 1.4 and RHTAP 1.3

Issue:
HACDOCS-1157

Output:

Preview link: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-725/plugins-rhdh-configure/#enabling-argo-cd-rollouts

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 21, 2024 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-725/ @ 02/25/25 17:17:09

karthikjeeyar
karthikjeeyar reviewed Nov 22, 2024
View reviewed changes
karthikjeeyar
karthikjeeyar approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 22, 2024
@subhashkhileri
Copy link
Member

subhashkhileri commented Nov 25, 2024

LGTM

@themr0c themr0c requested a review from Gerry-Forde November 28, 2024 09:03
@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Dec 2, 2024
linfraze
linfraze reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the content! A couple suggestions.

linfraze
linfraze approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea for the docs team to revisit this file in the future to apply modularization stnds and ensure the steps are formatted properly

linfraze
linfraze reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be modularized.

Also, it seems that there are quite a few optional and conditional steps. Let's be sure that we are following the IBM guidelines for formatting those types of steps so that the docs are clear and consistent.

https://www.ibm.com/docs/en/ibm-style?topic=format-procedures#indicating-optional-and-conditional-steps

linfraze
linfraze approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! :)

@gtrivedi88
Copy link
Contributor Author

gtrivedi88 commented Feb 25, 2025

@Gerry-Forde @linfraze Need help with merging this PR. I do not have merge access rights.

@jmagak
Copy link
Member

jmagak commented Feb 27, 2025

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Feb 27, 2025

@jmagak: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak merged commit e24d5ca into redhat-developer:main Feb 27, 2025
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Feb 27, 2025

@jmagak: new pull request created: #955

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 27, 2025
Merged
@jmagak
Copy link
Member

jmagak commented Mar 6, 2025

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Mar 6, 2025

@jmagak: new pull request created: #972

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagak jmagak jmagak approved these changes

@Gerry-Forde Gerry-Forde Awaiting requested review from Gerry-Forde

+2 more reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

@linfraze linfraze linfraze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthikjeeyar karthikjeeyar

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gtrivedi88 @rhdh-bot @subhashkhileri @jmagak @openshift-cherrypick-robot @karthikjeeyar @linfraze @themr0c