Skip to content

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Dec 2, 2024

The title is already defined in the assembly (consistent with other titles).

Fixes the build in Pantheon.

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):

Add the relevant labels to the Pull Request.
Issue:

@themr0c
Copy link
Member Author

themr0c commented Dec 2, 2024

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@themr0c themr0c requested a review from jmagak December 2, 2024 14:18
@themr0c themr0c changed the title No duplicate title fix: No duplicate title Dec 2, 2024
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Dec 2, 2024

Copy link
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gerry-Forde
Copy link
Member

@themr0c Should the Preface still appear in the preview of this title?
c.c. @jmagak

@themr0c
Copy link
Member Author

themr0c commented Dec 2, 2024

@Gerry-Forde I noticed that too. Ccutil is not handling properly the metadata. This is the next shift-left iteration.

@themr0c themr0c merged commit 6631345 into main Dec 2, 2024
3 checks passed
@themr0c themr0c deleted the themr0c-patch-1 branch December 2, 2024 15:26
@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: new pull request created: #762

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants