-
Notifications
You must be signed in to change notification settings - Fork 58
RHIDP-1848: Updates the setting up RBAC permission #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHIDP-1848: Updates the setting up RBAC permission #906
Conversation
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-906/ @ 02/25/25 16:51:12 |
184c12b to
5d04431
Compare
linfraze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and suggestions <3
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
PatAKnight
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
linfraze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few considerations
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
modules/authorization/proc-enabling-guest-access-for-rbac-frontend-plugin.adoc
Outdated
Show resolved
Hide resolved
a91e3c3 to
ef6eac1
Compare
linfraze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just applied some fixes that the Vale linter caught, but lgtm
|
@linfraze, I made slight adjustments to the text. Let me know what you think. |
|
/cherry-pick release-1.4 |
|
/cherry-pick release 1.5 |
|
/cherry-pick release-1.3 |
|
@hmanwani-rh: new pull request created: #964 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@hmanwani-rh: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@hmanwani-rh: new pull request created: #965 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.5 |
|
@hmanwani-rh: new pull request created: #966 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.3, 1.4
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-1848
Preview: Configuring guest access with RBAC UI