Skip to content

PR title and source.json should incl packaged version #18

@christoph-jerolimov

Description

@christoph-jerolimov

PRs like this:

makes it difficult to understand which version this bundles. For me it looks like it picks a "random" Git hash/repo-ref. But @davidfestal explained me that it already picks up the latest release of an npm package.

To make it more explicit and readable I like to suggest that the title should include that npm version.

It would be nice if the source.json also includes this version. This makes it easier later to grep the repo for specific versions.

Current workspaces/npm/source.json (manually formatted for readability):

{
  "repo": "https://github.com/backstage/community-plugins",
  "repo-ref": "335037a9f57eef5a989363cb9779cfaeb8c81f9b",
  "repo-flat": false
}

And kind of extra attributes like this would be great:

{
  "repo": "https://github.com/backstage/community-plugins",
  "repo-ref": "335037a9f57eef5a989363cb9779cfaeb8c81f9b",
  "repo-flat": false,
  "workspace-path": "workspaces/npm",
  "npm-version": "1.0.0"
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions