chore: code cleanup and api reports

Author: PreetiW

workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization-backend/src/routes/costManagementAccess.ts

@@ -95,9 +95,6 @@ export const getCostManagementAccess: (
       clustersData.data?.forEach(
         (cluster: { value: string; cluster_alias: string }) => {
           if (cluster.cluster_alias && cluster.value) {
-            logger.info(
-              `Cluster: ${cluster.cluster_alias} -> ${cluster.value}`,
-            );
             clusterDataMap[cluster.cluster_alias] = cluster.value;
           }
         },
@@ -132,13 +129,6 @@ export const getCostManagementAccess: (
   }
 
   // RBAC Filtering: Single batch call for both cluster and cluster-project permissions
-  logger.info(
-    `Checking permissions for ${
-      Object.keys(clusterDataMap).length
-    } clusters and ${allProjects.length} projects`,
-  );
-  logger.info(`Cluster names: ${Object.keys(clusterDataMap).join(', ')}`);
-  logger.info(`Projects: ${allProjects.join(', ')}`);
 
   const { authorizedClusterIds, authorizedClusterProjects } =
     await filterAuthorizedClustersAndProjects(
@@ -150,16 +140,6 @@ export const getCostManagementAccess: (
       'cost',
     );
 
-  logger.info(
-    `Authorization results: ${authorizedClusterIds.length} clusters, ${authorizedClusterProjects.length} cluster-project combinations`,
-  );
-  logger.info(`Authorized clusters: ${authorizedClusterIds.join(', ')}`);
-  logger.info(
-    `Authorized cluster-projects: ${authorizedClusterProjects
-      .map(cp => `${cp.cluster}.${cp.project}`)
-      .join(', ')}`,
-  );
-
   // Combine cluster names from both cluster-level and project-level permissions
   const finalAuthorizedClusterNames = [
     ...new Set([

workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization-backend/src/util/checkPermissions.ts

@@ -238,12 +238,6 @@ export const filterAuthorizedClustersAndProjects = async (
   const allClusterNames: string[] = Object.keys(clusterDataMap);
   const allClusterIds: string[] = Object.values(clusterDataMap);
 
-  console.log(
-    `[DEBUG] filterAuthorizedClustersAndProjects called with permissionType: ${permissionType}`,
-  );
-  console.log(`[DEBUG] Clusters to check: ${allClusterNames.join(', ')}`);
-  console.log(`[DEBUG] Projects to check: ${allProjects.join(', ')}`);
-
   // Early exit if no data
   if (allClusterNames.length === 0) {
     return {
@@ -269,7 +263,6 @@ export const filterAuthorizedClustersAndProjects = async (
   const clusterPermissionRequests: AuthorizePermissionRequest[] =
     allClusterNames.map(clusterName => {
       const perm = getClusterPermission(clusterName);
-      console.log(`[DEBUG] Checking cluster permission: ${perm.name}`);
       return { permission: perm };
     });
 
@@ -291,42 +284,20 @@ export const filterAuthorizedClustersAndProjects = async (
       permissionType === 'cost' ? clusterName : clusterId;
     const decision = clusterDecisions[i].result;
 
-    console.log(
-      `[DEBUG] Cluster "${clusterName}" (id: ${clusterId}): ${decision}`,
-    );
-
     if (decision === AuthorizeResult.ALLOW) {
       // User has full cluster access
-      console.log(
-        `[DEBUG] Adding "${clusterIdentifier}" to clustersWithFullAccess`,
-      );
       clustersWithFullAccess.add(clusterIdentifier);
     } else {
       // No cluster access - will need to check project-level permissions
-      console.log(
-        `[DEBUG] Adding cluster index ${i} to clustersWithoutFullAccess`,
-      );
       clustersWithoutFullAccess.push(i);
     }
   }
 
-  console.log(
-    `[DEBUG] Clusters with full access: ${Array.from(
-      clustersWithFullAccess,
-    ).join(', ')}`,
-  );
-  console.log(
-    `[DEBUG] Clusters without full access (count): ${clustersWithoutFullAccess.length}`,
-  );
-
   // Step 2: Check project-level permissions only for clusters without full access
   const authorizedClusterProjects: ClusterProjectResult[] = [];
   const clustersGrantedViaProjects = new Set<string>();
 
   if (clustersWithoutFullAccess.length > 0 && allProjects.length > 0) {
-    console.log(
-      `[DEBUG] Checking project-level permissions for ${clustersWithoutFullAccess.length} clusters`,
-    );
     const numProjectChecks =
       clustersWithoutFullAccess.length * allProjects.length;
     const projectPermissionRequests: AuthorizePermissionRequest[] = new Array(
@@ -344,16 +315,10 @@ export const filterAuthorizedClustersAndProjects = async (
       const clusterIdentifier =
         permissionType === 'cost' ? clusterName : clusterId;
 
-      console.log(
-        `[DEBUG] Building project checks for cluster "${clusterName}"`,
-      );
-
       for (let j = 0; j < allProjects.length; j++) {
         const projectName = allProjects[j];
         const perm = getClusterProjectPermission(clusterName, projectName);
 
-        console.log(`[DEBUG] Will check: ${perm.name}`);
-
         projectPermissionRequests[idx] = {
           permission: perm,
         };
@@ -376,45 +341,22 @@ export const filterAuthorizedClustersAndProjects = async (
     // Process project-level results
     for (let i = 0; i < projectDecisions.length; i++) {
       const decision = projectDecisions[i].result;
-      const map = projectPermissionMap[i];
-
-      console.log(
-        `[DEBUG] Project permission "${map.cluster}.${map.project}": ${decision}`,
-      );
 
       if (decision === AuthorizeResult.ALLOW) {
         const result = projectPermissionMap[i];
         authorizedClusterProjects.push(result);
-        console.log(
-          `[DEBUG] Adding cluster "${result.cluster}" to clustersGrantedViaProjects`,
-        );
         // Project-level permission also grants cluster access
         clustersGrantedViaProjects.add(result.cluster);
       }
     }
   }
 
-  console.log(
-    `[DEBUG] Clusters granted via projects: ${Array.from(
-      clustersGrantedViaProjects,
-    ).join(', ')}`,
-  );
-
   // Step 3: Combine clusters from both full access and project-level grants
   const authorizedClusterIds = [
     ...clustersWithFullAccess,
     ...clustersGrantedViaProjects,
   ];
 
-  console.log(
-    `[DEBUG] Final authorized clusters: ${authorizedClusterIds.join(', ')}`,
-  );
-  console.log(
-    `[DEBUG] Final authorized cluster-projects: ${authorizedClusterProjects
-      .map(cp => `${cp.cluster}.${cp.project}`)
-      .join(', ')}`,
-  );
-
   return {
     authorizedClusterIds,
     authorizedClusterProjects,

workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization-common/report-clients.api.md

@@ -113,6 +113,7 @@ export interface CostManagementSlimApi {
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{
@@ -139,6 +140,7 @@ export interface CostManagementSlimApi {
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{
@@ -187,6 +189,7 @@ export class CostManagementSlimClient implements CostManagementSlimApi {
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{
@@ -207,10 +210,13 @@ export class CostManagementSlimClient implements CostManagementSlimApi {
       links?: any;
     }>
   >;
+  // Warning: (tsdoc-param-tag-with-invalid-name) The @param block should be followed by a valid parameter name: The identifier cannot non-word characters
+  // Warning: (tsdoc-param-tag-with-invalid-name) The @param block should be followed by a valid parameter name: The identifier cannot non-word characters
   searchOpenShiftProjects(
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{

workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization-common/report-permissions.api.md

@@ -5,6 +5,12 @@
 ```ts
 import { BasicPermission } from '@backstage/plugin-permission-common';
 
+// @public (undocumented)
+export const costClusterProjectPermission: (
+  clusterName: string,
+  projectName: string,
+) => BasicPermission;
+
 // @public (undocumented)
 export const costClusterSpecificPermission: (
   clusterName: string,

workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization-common/report.api.md

@@ -111,6 +111,7 @@ export interface CostManagementSlimApi {
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{
@@ -137,6 +138,7 @@ export interface CostManagementSlimApi {
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{
@@ -185,6 +187,7 @@ export class CostManagementSlimClient implements CostManagementSlimApi {
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{
@@ -205,10 +208,13 @@ export class CostManagementSlimClient implements CostManagementSlimApi {
       links?: any;
     }>
   >;
+  // Warning: (tsdoc-param-tag-with-invalid-name) The @param block should be followed by a valid parameter name: The identifier cannot non-word characters
+  // Warning: (tsdoc-param-tag-with-invalid-name) The @param block should be followed by a valid parameter name: The identifier cannot non-word characters
   searchOpenShiftProjects(
     search?: string,
     options?: {
       token?: string;
+      limit?: number;
     },
   ): Promise<
     TypedResponse<{