-
Notifications
You must be signed in to change notification settings - Fork 85
RHIDP-9710 Create aggregated metrics API for Scorecard backend plugin #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHIDP-9710 Create aggregated metrics API for Scorecard backend plugin #2020
Conversation
Signed-off-by: Ihor Mykhno <[email protected]>
Signed-off-by: Ihor Mykhno <[email protected]>
Signed-off-by: Ihor Mykhno <[email protected]>
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
|
@imykhno can you add changeset? |
workspaces/scorecard/plugins/scorecard-backend/docs/aggregation.md
Outdated
Show resolved
Hide resolved
workspaces/scorecard/plugins/scorecard-backend/docs/aggregation.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Ihor Mykhno <[email protected]>
Signed-off-by: Ihor Mykhno <[email protected]>
Signed-off-by: Ihor Mykhno <[email protected]>
…ecified Signed-off-by: Ihor Mykhno <[email protected]>
|
dzemanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested that /metrics endpoint returns correctly metrics meta information without scorecard.read permission. Tested that filtering by metricIds and datasource works correctly. Tested you get 400 when you try to filter by both



Hey, I just made a Pull Request!
Improvement aggregation logic after merge the #1984.
In this PR:
/metrics/:metricId/catalog/aggregationto/metrics/:metricId/catalog/aggregations. Ref - RHIDP-9710 Create aggregated metrics API for Scorecard backend plugin #1984 (comment)/metricsendpoint✔️ Checklist