Skip to content

chore(e2e): translation support for core e2e tests #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 22, 2025
Merged

chore(e2e): translation support for core e2e tests #3555

merged 22 commits into from
Oct 22, 2025

Conversation

@teknaS47
Copy link
Member

Description

Added translation tests for existing core plugins e2e tests mentioned in the issue below

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@teknaS47
Copy link
Member Author

/cc @christoph-jerolimov

@github-actions
Copy link
Contributor

The image is available at:

@invincibleJai
Copy link
Member

/retest

@invincibleJai
Copy link
Member

/cherrypick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HusneShabbir
Copy link
Contributor

/retest

@github-actions
Copy link
Contributor

The image is available at:

@teknaS47
Copy link
Member Author

/retest

@github-actions
Copy link
Contributor

The image is available at:

@teknaS47
Copy link
Member Author

/retest

@github-actions
Copy link
Contributor

The image is available at:

karthikjeeyar
karthikjeeyar reviewed Oct 17, 2025
View reviewed changes
@teknaS47
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Oct 21, 2025
@github-actions
Copy link
Contributor

The image is available at:

@github-actions
Copy link
Contributor

The image is available at:

@ciiay
Copy link
Member

ciiay commented Oct 21, 2025

/retest

2 similar comments
@ciiay
Copy link
Member

ciiay commented Oct 21, 2025

/retest

@ciiay
Copy link
Member

ciiay commented Oct 21, 2025

/retest

its-mitesh-kumar and others added 2 commits October 22, 2025 07:46
@github-actions
Copy link
Contributor

The image is available at:

@github-actions
Copy link
Contributor

The image is available at:

@github-actions
Copy link
Contributor

The image is available at:

@rostalan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, HusneShabbir, invincibleJai, jmagak, karthikjeeyar, rostalan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 659c572 into redhat-developer:main Oct 22, 2025
14 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: #3555 failed to apply on top of branch "release-1.8":

Applying: chore(e2e): translation support for core e2e tests
Using index info to reconstruct a base tree...
M	e2e-tests/playwright/e2e/extensions.spec.ts
Falling back to patching base and 3-way merge...
Removing e2e-tests/playwright/e2e/localization/locale-test.spec.ts
Auto-merging e2e-tests/playwright/e2e/extensions.spec.ts
CONFLICT (content): Merge conflict in e2e-tests/playwright/e2e/extensions.spec.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 chore(e2e): translation support for core e2e tests

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chadcrum pushed a commit to chadcrum/rhdh that referenced this pull request Oct 23, 2025
@teknaS47 @its-mitesh-kumar @chadcrum
chore(e2e): translation support for core e2e tests (redhat-developer#…
369dc02 
…3555)

* chore(e2e): translation support for core e2e tests

* added missing translations, removed homepage translations

* adding test suite for running french translations

* minor changes

* rebase and fix

* removing custom plugins

Signed-off-by: its-mitesh-kumar <[email protected]>

* fix

* fix

---------

Signed-off-by: its-mitesh-kumar <[email protected]>
Co-authored-by: its-mitesh-kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdrapela zdrapela zdrapela left review comments

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@psrna psrna Awaiting requested review from psrna

@subhashkhileri subhashkhileri Awaiting requested review from subhashkhileri

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

+1 more reviewer

@jmagak jmagak jmagak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@invincibleJai invincibleJai

@karthikjeeyar karthikjeeyar

@rostalan rostalan

@HusneShabbir HusneShabbir

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.