FUSETOOLS2-1342 - fix eslint errors

- Unnecessary escape character: \"
- Don't use `String` as a type. Use string instead
- XXX is never reassigned. Use 'const' instead
- Mixed spaces and tabs
- Type boolean trivially inferred from a boolean literal, remove type
annotation

Signed-off-by: Aurélien Pupier <[email protected]>

Author: apupier

src/extension.ts

@@ -142,7 +142,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<any> {
 				.use(taskLists, {enabled: true, label: true})
 				.use(markdownItAttrs, {});
 		}
-	  };
+	};
 }
 
 function createIntegrationsView(): void {

src/extensionFunctions.ts

@@ -601,7 +601,7 @@ export function collectElements(tagname: string, html? : string | undefined) : a
 	if (html) {
 		const document = parse(html);
 		const links = document.querySelectorAll(tagname);
-		for (let element of links.values()) {
+		for (const element of links.values()) {
 			elements.push(element);
 		}
 	}
@@ -612,7 +612,7 @@ export function gatherAllRequirementsLinks() : any[] {
 	const requirements = [];
 	if (didactManager.active()?.getCurrentHTML()) {
 		const links = collectElements("a", didactManager.active()?.getCurrentHTML());
-		for (let element of links.values()) {
+		for (const element of links.values()) {
 			if (element.getAttribute('href')) {
 				const href = element.getAttribute('href');
 				for(const check of requirementCommandLinks) {
@@ -631,7 +631,7 @@ export function gatherAllCommandsLinks(): any[] {
 	const commandLinks = [];
 	if (didactManager.active()?.getCurrentHTML()) {
 		const links = collectElements("a", didactManager.active()?.getCurrentHTML());
-		for (let element of links.values()) {
+		for (const element of links.values()) {
 			if (element.getAttribute('href')) {
 				const href = element.getAttribute('href');
 				if (href.startsWith(commandPrefix)) {
@@ -986,7 +986,7 @@ export async function pasteClipboardToActiveEditorOrPreviouslyUsedOne() : Promis
 }
 
 export async function findOpenEditorForFileURI(uri: vscode.Uri) : Promise<vscode.TextEditor | undefined> {
-	for (let editor of vscode.window.visibleTextEditors.values()) {
+	for (const editor of vscode.window.visibleTextEditors.values()) {
 		if (editor.document.uri === uri) {
 			return editor;
 		}
@@ -1025,7 +1025,7 @@ function getTimeElementsForAdoc(content : string) : any[] {
 
 function processTimeTotalForMD(content : string) : number {
 	let total = 0;
-	let elements : any[] = getTimeElementsForMD(content);
+	const elements : any[] = getTimeElementsForMD(content);
 	if (elements && elements.length > 0) {
 		elements.forEach(element => {
 			const timeAttr = element.getAttribute("time");
@@ -1042,7 +1042,7 @@ function processTimeTotalForMD(content : string) : number {
 
 function processTimeTotalForAdoc(content : string) : number {
 	let total = 0;
-	let elements : any[] = getTimeElementsForAdoc(content);
+	const elements : any[] = getTimeElementsForAdoc(content);
 	if (elements && elements.length > 0) {
 		elements.forEach(element => {
 			const classAttr : string = element.getAttribute("class");

src/nodeProvider.ts

@@ -173,13 +173,13 @@ export class DidactNodeProvider implements vscode.TreeDataProvider<SimpleNode> {
 		const classAttr : string | undefined = divElement.getAttribute("class");
 		if (classAttr) {
 			const splitArray : string[] = classAttr.split(' ');
-			for (let chunk of splitArray) {
+			for (const chunk of splitArray) {
 				if (chunk.startsWith('time=')) {
 					const splitTime = chunk.split('=')[1];
 					const timeValue = Number(splitTime);
 					if (divElement.childNodes.length > 0) {
 						const children = divElement.childNodes;
-						for (let rawChild of children) {
+						for (const rawChild of children) {
 							if (rawChild instanceof HTMLElement) {
 								const child: HTMLElement = rawChild;
 								if (child.tagName.startsWith('H')) {
@@ -263,7 +263,7 @@ export class DidactNodeProvider implements vscode.TreeDataProvider<SimpleNode> {
 		if (catNode) {
 			const treeItems : SimpleNode[] = await this.getChildren(catNode);
 			let foundNode : SimpleNode | null = null;
-			for (let element of treeItems) {
+			for (const element of treeItems) {
 				if (element.uri === uri && element.category === category) {
 					foundNode = element;
 					break;

src/test/suite/Utils.ts

@@ -67,8 +67,8 @@ export async function validateCommands(testUri : vscode.Uri) : Promise<boolean>
 	return false;
 }
 
-export async function getFailedCommands(commands : any[]) : Promise<String[]> {
-	let failedCommandList : String[] = [];
+export async function getFailedCommands(commands : any[]) : Promise<string[]> {
+	const failedCommandList : string[] = [];
 	if (commands && commands.length > 0) {
 		const vsCommands : string[] = await vscode.commands.getCommands(true);
 		for(const command of commands) {

src/test/suite/commandHandler.test.ts

@@ -51,7 +51,6 @@ suite("Command Handler tests", function () {
 		await processInputs(didactUri);
 		expect(didactManager.active()).to.not.equal(undefined);
 
-		let changed = false;
 		const panel = didactManager.active();
 		expect(panel).to.not.equal(null);
 		expect(panel).to.not.equal(undefined);

src/test/suite/completions.test.ts

@@ -76,10 +76,10 @@ async function testWeGetExpectedResult(textToInsert : string, expectedResult: st
 async function initializeTextEditor(textEditor: TextEditor, initializeWith = "") {
 	const doc = textEditor.document;
 	await textEditor.edit((editBuilder) => {
-	  editBuilder.delete(new Range(new Position(0, 0), doc.positionAt(doc.getText().length)));
+		editBuilder.delete(new Range(new Position(0, 0), doc.positionAt(doc.getText().length)));
 	});
 	await textEditor.edit((editBuilder) => {
-	  editBuilder.insert(new Position(0, 0), initializeWith);
+		editBuilder.insert(new Position(0, 0), initializeWith);
 	});
 	expect(doc.getText()).to.be.equal(initializeWith);
 }

src/test/suite/registry.test.ts

@@ -139,7 +139,7 @@ suite('Didact registry test suite', () => {
 	});
 
 	test('append registry from environment variable', async() => {
-		const tutsToAppend : String = '[{"name":"AppendMe2","category":"AppendedCat2","sourceUri":"https%3A%2F%2Fraw.githubusercontent.com%2Fredhat-developer%2Fvscode-didact%2Fmain%2Fexamples%2Fregistry.example.didact.md"}]';
+		const tutsToAppend = '[{"name":"AppendMe2","category":"AppendedCat2","sourceUri":"https%3A%2F%2Fraw.githubusercontent.com%2Fredhat-developer%2Fvscode-didact%2Fmain%2Fexamples%2Fregistry.example.didact.md"}]';
 		process.env[DIDACT_APPEND_REGISTERED_SETTING] = tutsToAppend.toString();
 
 		const envVarJson = getAppendRegisteredSettingFromEnv();

src/test/suite/stubDemoTutorial.test.ts

@@ -36,7 +36,7 @@ suite('stub out a tutorial', () => {
 
 	test('that we can send an echo command to the terminal and get the response', async () => {
 		const name = 'echoTerminal';
-		const text = `echo \"Hello World ${name}\"`;
+		const text = `echo "Hello World ${name}"`;
 		const result = `Hello World echoTerminal`;
 		await validateTerminalResponse(name, text, result);
 	});
@@ -52,7 +52,7 @@ suite('stub out a tutorial', () => {
 					const testUri = new DidactUri(href, ctxt);
 					const textToParse = testUri.getText();
 					const userToParse = testUri.getUser();
-					let outputs : string[] = [];
+					const outputs : string[] = [];
 					if (textToParse) {
 						handleText(textToParse, outputs);
 					} else if (userToParse) {

src/utils.ts

@@ -290,7 +290,7 @@ export async function getCurrentFileSelectionPath(): Promise<Uri> {
 	await commands.executeCommand('copyFilePath');
 	const copyPath = await env.clipboard.readText();
 	if (fs.existsSync(`"${copyPath}"`) && fs.lstatSync(`"${copyPath}"`).isFile() ) {
-	  return Uri.file(`"${copyPath}"`);
+		return Uri.file(`"${copyPath}"`);
 	}
   }
   throw new Error("Can not determine current file selection");
@@ -395,17 +395,17 @@ function validateTutorialNameInput(value: string, tutorialsForValidation : strin
 		}
 		return null;
 	}
-  	return `${value} is invalid`;
+	return `${value} is invalid`;
 }
 
 async function quickPickCategory(
 	categories: string[],
-	canSelectMany: boolean = false,
-	acceptInput: boolean = true): Promise<string[]> {
-	let options = categories.map(tag => ({ label: tag }));
+	canSelectMany = false,
+	acceptInput = true): Promise<string[]> {
+	const options = categories.map(tag => ({ label: tag }));
 
 	return new Promise((resolve, _) => {
-		let quickPick = window.createQuickPick();
+		const quickPick = window.createQuickPick();
 		let placeholder = "Select a Tutorial Category.";
 
 		if (acceptInput) {