FUSETOOLS2-996 - instead of erroring out, open terminal if it exists (#422)

bfitzpat · web-flow · commit 8cc78f59b96a · 2021-02-18T07:37:42.000-07:00
Signed-off-by: Brian Fitzpatrick &lt;bfitzpat@redhat.com&gt;
diff --git a/src/extensionFunctions.ts b/src/extensionFunctions.ts
@@ -155,8 +155,10 @@ export async function startTerminal(...rest: any[]): Promise<void>{ //name:strin
 		}
 	}
 	if (name) {
-		if (findTerminal(name)) {
-			throw new Error(`Terminal ${name} already exists`);
+		const oldTerm = findTerminal(name);
+		if (oldTerm) {
+			oldTerm.show();
+			return;
 		}
 	}
 	let terminal : vscode.Terminal | undefined = undefined;

Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,10 @@ export async function startTerminal(...rest: any[]): Promise<void>{ //name:strin`
`155`	`155`	`}`
`156`	`156`	`}`
`157`	`157`	`if (name) {`
`158`		`- if (findTerminal(name)) {`
`159`		- throw new Error(`Terminal ${name} already exists`);
	`158`	`+ const oldTerm = findTerminal(name);`
	`159`	`+ if (oldTerm) {`
	`160`	`+ oldTerm.show();`
	`161`	`+ return;`
`160`	`162`	`}`
`161`	`163`	`}`
`162`	`164`	`let terminal : vscode.Terminal \| undefined = undefined;`