Skip to content
This repository was archived by the owner on May 11, 2022. It is now read-only.

Conversation

@pwright
Copy link
Contributor

@pwright pwright commented Jul 13, 2021

I believe this issue was caused by my exercising new feature at https://code.visualstudio.com/updates/v1_58#_terminals-in-the-editor-area
Altho I had to mess around to get things going, so not 100% sure

I believe this issue was caused by my exercising new feature at https://code.visualstudio.com/updates/v1_58#_terminals-in-the-editor-area
Altho I had to mess around to get things going, so not 100% sure
@bfitzpat
Copy link
Collaborator

Very interesting. We have some issues with supporting 1.58.x as a version right now anyway - #639 doesn't build due to some weird changes upstream.

Thanks for sharing this and we'll definitely keep it for when we update!

Copy link
Collaborator

@bfitzpat bfitzpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a +1

@bfitzpat
Copy link
Collaborator

So @pwright just to confirm... this is when running Didact (which is built against 1.57.x) on a vscode instance that's 1.58.x?

@pwright
Copy link
Contributor Author

pwright commented Jul 13, 2021

@bfitzpat yes that's correct

@bfitzpat bfitzpat merged commit 419c52c into redhat-developer:master Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants