Report errors when configuring a wrong runtime path (#1625)

Signed-off-by: Jinbo Wang <[email protected]>

Author: testforstephen

package.json

@@ -501,7 +501,8 @@
               },
               "path": {
                 "type": "string",
-                "description": "JDK path.\nOn Windows, backslashes must be escaped, i.e.\n\"path\":\"C:\\\\Program Files\\\\Java\\\\jdk1.8.0_161\"."
+                "pattern": ".*(?<!\\/bin|\\/bin\\/|\\\\bin|\\\\bin\\\\)$",
+                "description": "JDK home path. Should be the JDK installation directory, not the Java bin path.\n On Windows, backslashes must be escaped, i.e.\n\"path\":\"C:\\\\Program Files\\\\Java\\\\jdk1.8.0_161\"."
               },
               "sources": {
                 "type": "string",

src/commands.ts

@@ -218,4 +218,6 @@ export namespace Commands {
     export const LEARN_MORE_ABOUT_REFACTORING = '_java.learnMoreAboutRefactorings';
 
     export const TEMPLATE_VARIABLES = '_java.templateVariables';
+
+    export const RUNTIME_VALIDATION_OPEN = 'java.runtimeValidation.open';
 }

src/extension.ts

@@ -179,7 +179,8 @@ export function activate(context: ExtensionContext): Promise<ExtensionAPI> {
 						clientDocumentSymbolProvider: true,
 						gradleChecksumWrapperPromptSupport: true,
 						resolveAdditionalTextEditsSupport: true,
-						advancedIntroduceParameterRefactoringSupport: true
+						advancedIntroduceParameterRefactoringSupport: true,
+						actionableRuntimeNotificationSupport: true
 					},
 					triggerFiles,
 				},

src/standardLanguageClient.ts

@@ -44,6 +44,10 @@ export class StandardLanguageClient {
 			commands.executeCommand(Commands.SHOW_SERVER_TASK_STATUS);
 		}
 
+		context.subscriptions.push(commands.registerCommand(Commands.RUNTIME_VALIDATION_OPEN, () => {
+			commands.executeCommand("workbench.action.openSettings", "java.configuration.runtimes");
+		}));
+
 		serverStatus.initialize();
 		serverStatus.onServerStatusChanged(status => {
 			if (status === ServerStatusKind.Busy) {

test/standard-mode-suite/extension.test.ts

@@ -64,7 +64,8 @@ suite('Java Language Extension - Standard', () => {
 				Commands.SHOW_JAVA_REFERENCES,
 				Commands.SHOW_SERVER_TASK_STATUS,
 				Commands.SWITCH_SERVER_MODE,
-				Commands.UPDATE_SOURCE_ATTACHMENT
+				Commands.UPDATE_SOURCE_ATTACHMENT,
+				Commands.RUNTIME_VALIDATION_OPEN
 			].sort();
 			const foundJavaCommands = commands.filter((value) => {
 				return JAVA_COMMANDS.indexOf(value)>=0 || value.startsWith('java.');